On Thu, 25 Apr 2024 at 10:10, Chao Li <lic...@loongson.cn> wrote: > > Hi Gerd, > > > Thanks, > Chao > On 2024/4/25 15:40, Gerd Hoffmann wrote: > > Hi, > > +EFI_GUID mFwCfgSelectorAddressGuid = FW_CONFIG_SELECTOR_ADDRESS_HOB_GUID; > +EFI_GUID mFwCfgDataAddressGuid = FW_CONFIG_DATA_ADDRESS_HOB_GUID; > +EFI_GUID mFwCfgDmaAddressGuid = FW_CONFIG_DMA_ADDRESS_HOB_GUID; > > Oh. I assumed that would be obvious (because it's common practice for > HOBs), but I was thinking about a single HOB containing a struct with > all three values instead of a separate HOB for each value. > > If uses a single HOB, it must define a structure in this library, and it may > be more complicated to build and parse the HOB. >
Please use a single HOB, and avoid global variables in PEI (PEI modules may execute in place from read-only NOR flash, so global variables are not allowed in PEI) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118280): https://edk2.groups.io/g/devel/message/118280 Mute This Topic: https://groups.io/mt/105724969/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
