Hi all, On Fri, Apr 12, 2024 at 06:03:35PM +0800, joeyli via groups.io wrote: > Hi experts, > > On Fri, Apr 12, 2024 at 03:25:56PM +0800, Lee, Chun-Yi wrote: > > From: Chun-Yi Lee <j...@suse.com> > > > > RISC-V ovmf used VirtualRealTimeClockLib but the default epoch is a > > compilation time. It causes that the RISC-V ovmf binary image is NOT > > reproducible. > > > > This patch added the support of SOURCE_DATE_EPOCH by printenv command. > > If SOURCE_DATE_EPOCH be found then we use it as BUILD_EPOCH. Otherwise > > we run date command for setting BUILD_EPOCH. > > > > For distributions want a reproducible RISC-V ovmf image, they should > > export SOURCE_DATE_EPOCH environment variable before building ovmf. > > > > References: https://reproducible-builds.org/docs/source-date-epoch/ > > Cc: Pete Batard <p...@akeo.ie> > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Signed-off-by: Chun-Yi Lee <j...@suse.com> > > I have filed pull request: > > https://github.com/tianocore/edk2/pull/5550 >
Does anyone have suggestion against this patch. Or I missed anything for the submit request? Thanks! Joey Lee > > > --- > > .../Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf > > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf > > index 5d0f867..285e880 100644 > > --- > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf > > +++ > > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf > > @@ -34,4 +34,4 @@ > > > > # Current usage of this library expects GCC in a UNIX-like shell > > environment with the date command > > [BuildOptions] > > - GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`date +%s` > > + GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`printenv SOURCE_DATE_EPOCH || date > > +%s` > > -- > > 2.35.3 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118444): https://edk2.groups.io/g/devel/message/118444 Mute This Topic: https://groups.io/mt/105479031/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
