Replies inline.
On 8/1/24 3:45 AM, Leif Lindholm wrote:
On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote:
Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS
files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains
mappings from name to email address and GitHub usernames, which will
help people who want to email maintainers instead of using GitHub.
Add .github/workflows/AssignReviewers.yml which adds reviewers to a
Pull Request based on the content of the REVIEWERS file.
Signed-off-by: Rebecca Cran <[email protected]>
---
.github/workflows/AssignReviewers.yml | 28 ++
CODEOWNERS | 146 +++++++
CONTRIBUTORS.md | 68 +++
Maintainers.txt | 445 --------------------
REVIEWERS | 92 ++++
Readme.md | 32 +-
6 files changed, 361 insertions(+), 450 deletions(-)
diff --git a/.github/workflows/AssignReviewers.yml
b/.github/workflows/AssignReviewers.yml
new file mode 100644
index 000000000000..8ee95edbb2c1
--- /dev/null
+++ b/.github/workflows/AssignReviewers.yml
@@ -0,0 +1,28 @@
+## @file
+# Assign reviewers from a REVIEWERS file using CODEOWNERS syntax
If we're starting to do manual copying around of files between
repositories, can we add a manual audit trail?
I.e., full URL of repository, path inside repository, and commit hash?
I think my preference would be in this file header.
I'm not sure I understand. This file came from
https://github.com/mdkinney/github-action-assign-reviewers/blob/main/.github/workflows/AssignReviewers.yml.
Would you like me to add a note to .github/workflows/AssignReviewers.yml
to say that's where it came from?
diff --git a/CODEOWNERS b/CODEOWNERS
new file mode 100644
index 000000000000..bc86dd113398
--- /dev/null
+++ b/CODEOWNERS
@@ -0,0 +1,146 @@
...
+# Sophgo platforms and silicon
+/Platform/Sophgo/** @vlsunil
+/Silicon/Sophgo/SG2042Pkg/** @vlsunil
Not super important, but if we're doing this change it would be an
opportunity to re-sort the areas alphabetically, since that broke
somewhere along the way.
Fixed.
diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
new file mode 100644
index 000000000000..84882bcab2fa
--- /dev/null
+++ b/CONTRIBUTORS.md
@@ -0,0 +1,68 @@
+EDK II Platforms Maintainers and Reviewers
+=========================================================
+
+This file provides information about the people who maintain and review
+code for EDK II Platforms. For information about who from this file
+maintains (i.e. owns and can commit changes) and who reviews changes in
+various parts of the repo, see the CODEOWNERS and REVIEWERS files.
+
+| Name | e-mail address | Github username
|
+|------------------------|----------------------------------|------------------------------------------------------|
+| Leif Lindholm | [email protected] |
[@leiflindholm](https://github.com/leiflindholm) |
+| Michael D Kinney | [email protected] |
[@mdkinney](https://github.com/mdkinney) |
+| Ard Biesheuvel | [email protected] |
[@ardbiesheuvel](https://github.com/ardbiesheuvel) |
+| Abner Chang | [email protected] |
[@changab](https://github.com/changab) |
+| Abdul Lateef Attar | [email protected] |
[@abdattar](https://github.com/abdattar) |
+| Paul Grimes | [email protected] |
[@pbgrimes](https://github.com/pbgrimes) |
+| Eric Xing | [email protected] |
[@exinghr](https://github.com/exinghr) |
+| Ken Yao | [email protected] |
[@YSHRong](https://github.com/YSHRong) |
+| Duke Zhai | [email protected] |
[@mingxzha](https://github.com/mingxzha) |
+| Igniculus Fu | [email protected] |
[@fhh200000](https://github.com/fhh200000) |
+| Nhi Pham | [email protected] |
[@nhivp](https://github.com/nhivp) |
+| Chuong Tran | [email protected] |
[@chuongtranle](https://github.com/chuongtranle) |
+| Rebecca Cran | [email protected] |
[bcran](https://github.com/bcran) |
+| Thomas Abraham | [email protected] |
|
+| Sami Mujawar | [email protected] |
[@samimujawar](https://github.com/) |
+| Ray Ni | [email protected] |
[@niruiyu](https://github.com/niruiyu) |
+| Ilias Apalodimas | [email protected] |
[@apalos](https://github.com/apalos) |
+| Wenyi Xie | [email protected] |
|
+| Pedro Falcato | [email protected] |
[@heatd](https://github.com/heatd) |
+| Marvin H??user | [email protected] |
[@mhaeuser](https://github.com/mhaeuser) |
Is this charset corruption only in the email?
Yes. See
https://github.com/bcran/edk2-platforms/blob/github-pr/CONTRIBUTORS.md .
+| Sai Chaganty | [email protected] |
[@SaiChaganty](https://github.com/SaiChaganty) |
+| Nate DeSimone | [email protected] |
[@nate-desimone](https://github.com/nate-desimone) |
+| Liming Gao | [email protected] |
[@lgao4](https://github.com/lgao4) |
+| Eric Dong | [email protected] |
[@ydong10](https://github.com/ydong10) |
+| Dandan Bi | [email protected] |
[@dandanbi](https://github.com/dandanbi) |
+| Nickle Wang | [email protected] |
[@nicklela](https://github.com/nicklela) |
+| Zailiang Sun | [email protected] |
[@zailiangsun](https://github.com/zailiangsun) |
+| Yi Qian | [email protected] |
[@yqian4](https://github.com/yqian4) |
+| Chasel Chiu | [email protected] |
[@ChaselChiu](https://github.com/ChaselChiu) |
+| Benjamin Doron | [email protected] |
[@benjamindoron](https://github.com/benjamindoron) |
+| Jeremy Soller | [email protected] |
[@jackpot51](https://github.com/jackpot51) |
+| Deepika Kethi Reddy | [email protected] |
[@dkethire](https://github.com/dkethire) |
+| Kathappan Esakkithevar | [email protected] |
[@kesakkit](https://github.com/kesakkit) |
+| Heng Luo | [email protected] |
|
+| Rosen Chuang | [email protected] |
[@rbitw](https://github.com/rbitw) |
+| Saloni Kasbekar | [email protected] |
[@SaloniKasbekar](https://github.com/SaloniKasbekar) |
+| Bob Feng | [email protected] |
[@BobCF](https://github.com/BobCF) |
+| Yuwei Chen | [email protected] |
[@YuweiChen1110](https://github.com/YuweiChen1110) |
+| Sunil V L | [email protected] |
[@vlsunil](https://github.com/vlsunil) |
+| Daniel Schaefer | [email protected] |
[@JohnAZoidberg](https://github.com/JohnAZoidberg) |
+| Ashraf Ali S | [email protected] |
[@AshrafAliS](https://github.com/AshrafAliS) |
+| Bibo Mao | [email protected] |
|
+| Xianglai li | [email protected] |
|
+| Chao Li | [email protected] |
|
+| Marcin Wojtas | [email protected] |
[@wojtas-marcin](https://github.com/wojtas-marcin) |
+| Narinder Dhillon | [email protected] |
[@ndhillonm](https://github.com/ndhillonm) |
+| Meenakshi Aggarwal | [email protected] |
[@Meenakshi88](https://github.com/Meenakshi88) |
+| Theo Jehl | [email protected] |
[@theomacx86](https://github.com/theomacx86) |
+| Marcin Juszkiewicz | [email protected] |
[@hrw](https://github.com/hrw) |
+| Graeme Gregory | [email protected] |
|
+| Jeremy Linton | [email protected] |
[@jlinton](https://github.com/jlinton) |
+| Peng Xie | [email protected] |
|
+| Ling Jia | [email protected] |
|
+| Yiqi Shu | [email protected] |
|
+| dahogn | [email protected] |
[@dahogn](https://github.com/dahogn) |
+| meng-cz | [email protected] |
[@meng-cz](https://github.com/meng-cz) |
+| caiyuqing379 | [email protected] |
[@caiyuqing379](https://github.com/caiyuqing379) |
+| USER0FISH | [email protected] |
[@USER0FISH](https://github.com/USER0FISH) |
Likewise, could we sort this alphabetically by name string?
(If that's annoying, can you push it to a branch where I could pull it
down and sort it?)
Done. Took about 30 seconds (column select mode, copy lines to a file,
run through `sort`) :)
diff --git a/Maintainers.txt b/Maintainers.txt
deleted file mode 100644
index 824838486072..000000000000
--- a/Maintainers.txt
+++ /dev/null
@@ -1,445 +0,0 @@
,,,
-Any contributions to this branch should be submitted via email to the
-edk2-devel mailing list with a subject prefix of `[platforms]`. See
-[Laszlo's excellent
guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers)
for details
-on how to do this successfully.
+Any contributions to this branch should be submitted via GitHub Pull Request,
+or email to the edk2-devel mailing list with a subject prefix of
`[platforms]`. See
+[Laszlo's excellent
guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers)
for details on how to do this successfully.
Can you put back this line break?
Fixed.
+
+For details of who owns code in certain parts of the repo, see the CODEOWNERS
and
+REVIEWERS files. Look in CONTRIBUTORS.md to find out people's names and their
+email addresses.
+
+In general, you should not privately email the maintainer. You should
+email the edk2-devel list, and Cc the package maintainers and
+reviewers.
+
+If the package maintainer wants to hand over the role to other people,
Strictly speaking, the maintainership areas aren't broken up on a
package granularity here.
I've dropped the 'package' wording in favor of "area".
--
Rebecca
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120172): https://edk2.groups.io/g/devel/message/120172
Mute This Topic: https://groups.io/mt/107583542/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
