Hi Leif, Hope you're doing well. I hope you can find a few minutes on reviewing this patch set.
I appreciate your time. Thanks, Nhi ________________________________ From: [email protected] <[email protected]> on behalf of Nhi Pham via groups.io <[email protected]> Sent: Thursday, August 8, 2024 10:06 AM To: [email protected] <[email protected]> Cc: [email protected] <[email protected]>; Chuong Tran OS <[email protected]>; Rebecca Cran OS <[email protected]> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Hi Leif, I saw a comment from you in the Pull Request and I resolved it. Do you prefer to review in the Github PR? Should I send v3 to the mailing list? Regards, Nhi On 8/7/2024 1:47 PM, Nhi Pham wrote: > This updates the I2C library and implements SMBUS PEI/DXE drivers to > support IPMI SSIF in the Mt. Jade platform. > > v2: > - Refine the changes of the DwI2cLib per Leif's comments and update the > commit message accordingly. > - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. > > NOTE: Regarding the controller/target terminology, the function > prototype and comment are derived from edk2/MdePkg. In this patch set, I > am trying to avoid misusing the terms in the implementation instead of > altering the function prototype and comment with the PPI and Protocol. > > Nhi Pham (5): > AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation > AmpereSiliconPkg: Define PCDs for SMBUS and BMC > AmpereAltraPkg: Add SmbusHc PEI and DXE drivers > JadePkg: Add PlatformBmcReadyLib to support BMC ready check > Ampere/Jade: Enable IPMI SSIF > > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec > | 15 +- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > | 23 ++ > Platform/Ampere/JadePkg/Jade.dsc > | 2 + > Platform/Ampere/JadePkg/Jade.fdf > | 17 ++ > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReadyLib.inf > | 29 ++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf > | 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf > | 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h > | 95 +++++++ > Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h > | 11 +- > Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c > | 6 +- > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReadyLib.c > | 30 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c > | 261 ++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c > | 277 ++++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c > | 263 +++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c > | 129 ++++++++- > 15 files changed, 1227 insertions(+), 17 deletions(-) > create mode 100755 > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReadyLib.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h > create mode 100644 > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReadyLib.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120324): https://edk2.groups.io/g/devel/message/120324 Mute This Topic: https://groups.io/mt/107765352/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
