Raymond: I understand your fix. I agree this is a bug fix. I have no other comments to merge it for this stable tag.
Thanks Liming 发件人: [email protected] <[email protected]> 代表 Raymond Diaz via groups.io 发送时间: 2026年2月6日 3:05 收件人: Leif Lindholm <[email protected]>; [email protected]; [email protected] 抄送: Ard Biesheuvel <[email protected]>; Kinney, Michael D <[email protected]>; Michael Kubacki <[email protected]>; Andrew Fish <[email protected]>; Sami Mujawar <[email protected]> 主题: Re: [edk2-devel] 回复: [EXTERNAL] 回复: Push Label Request: Hey Leif, Yes, both Levi's and my PR are related. I had a change in our platform that fixed our PeilessSec due to global variables being set when running from Flash; this was causing a hang due to the attempt to set RO memory. Levi had pointed out in a different PR he had a similar change; this led me to upstream the change which you see here. This change is related to Levi's as I assume he had a similar issue in PEI before permanent memory becomes available. Both changes address the issue in a different way, however, removal of the globals in the common files is a safer approach. The idea is that each ArmFfaLib (SEC, DXE, PEI, and StandaloneMM) can cache their information as necessary. In SEC, this is not possible, which is why each time information is needed it gets queried. PEI is special because it can have permanent memory available and as such needs to query when it's not available but can cache it once it becomes available. I hope this helps! <mailto:[email protected]> @[email protected], I have addressed all of the comments and have the appropriate approvals. Please let me know if there is anything else you need from me, thanks! Raymond _____ From: Leif Lindholm <[email protected] <mailto:[email protected]> > Sent: Thursday, February 5, 2026 4:22 AM To: [email protected] <mailto:[email protected]> <[email protected] <mailto:[email protected]> >; [email protected] <mailto:[email protected]> <[email protected] <mailto:[email protected]> > Cc: Raymond Diaz <[email protected] <mailto:[email protected]> >; Ard Biesheuvel <ardb+tianocore@kernel. org <mailto:[email protected]> >; Kinney, Michael D <[email protected] <mailto:[email protected]> >; Michael Kubacki <[email protected] <mailto:[email protected]> >; Andrew Fish <[email protected] <mailto:[email protected]> >; Sami Mujawar <[email protected] <mailto:sami. [email protected]> > Subject: Re: [edk2-devel] 回复: [EXTERNAL] 回复: Push Label Request: I'm not entirely sure what's being asked here. One PR is related to another PR, which is closed, and the PR we want to get in for stable tag fixes PeilessSec, but all it does is remove global variable access? Can someone summarise into something more coherent please? Best Regards, Leif On Thu, 5 Feb 2026 at 02:55, gaoliming via groups.io <[email protected] <mailto:gaoliming=byosoft.com.cn@groups. io> > wrote: > > Ard, Leif, Sami: > > Have you any comments for MdeModulePkg: Remove global usage in ArmFfaCommon by Raymond-MS ・ Pull Request #12101 ・ tianocore/edk2? > > > > Thanks > > Liming > > 发件人: Raymond Diaz <[email protected] <mailto:[email protected]> > > 发送时间: 2026年2月4日 10:22 > 收件人: gaoliming <[email protected] <mailto:[email protected]. cn> >; [email protected] <mailto:[email protected]> > 抄送: 'Ard Biesheuvel' <[email protected] <mailto:[email protected]> >; 'Leif Lindholm' <[email protected] <mailto:[email protected]> >; 'Kinney, Michael D' <[email protected] <mailto:[email protected]> >; Michael Kubacki <[email protected] <mailto:[email protected]> >; 'Andrew Fish' <[email protected] <mailto:[email protected]> >; 'Sami Mujawar' <[email protected] <mailto:[email protected]> > > 主题: Re: [EXTERNAL] 回复: Push Label Request: > > > > Hello Liming, > > > > For 12101, those comments just recently came in. I just finished addressing them and pushing up changes. As for 12096, I am not requesting any push label or anything. I was just referencing the PR as it relates to 12101. As far as I can tell, 12096 could be dropped. I will sync with Levi about it. Thanks! > > > > Raymond > > ________________________________ > > From: gaoliming <[email protected] <mailto:[email protected]> > > Sent: Tuesday, February 3, 2026 5:39 PM > To: Raymond Diaz <[email protected] <mailto:raymonddiaz@microsoft. com> >; [email protected] <mailto:[email protected]> <[email protected] <mailto:[email protected]> > > Cc: 'Ard Biesheuvel' <[email protected] <mailto:[email protected]> >; 'Leif Lindholm' <[email protected] <mailto:[email protected]> >; 'Kinney, Michael D' <[email protected] <mailto:[email protected]> >; Michael Kubacki <[email protected] <mailto:[email protected]> >; 'Andrew Fish' <[email protected] <mailto:[email protected]> >; 'Sami Mujawar' <[email protected] <mailto:[email protected]> > > Subject: [EXTERNAL] 回复: Push Label Request: > > > > Raymond: > > > > For PR 12101, there are still some review comments to be resolved. > > For PR 12096, it is not reviewed yet. > > > > Coud you request the maintainers to review them first? > > > > Thanks > > Liming > > 发件人: Raymond Diaz <[email protected] <mailto:[email protected]> > > 发送时间: 2026年2月4日 7:38 > 收件人: [email protected] <mailto:[email protected]> ; Liming Gao <[email protected] <mailto:[email protected]> > > 主题: Push Label Request: > > > > Hello Liming, > > > > I am hoping to have: MdeModulePkg: Remove global usage in ArmFfaCommon by Raymond-MS ・ Pull Request #12101 ・ tianocore/edk2 added to the stable tag. This change is related to the change Levi shared with me: MdeModulePkg: ArmFfaLib: make ArmFfaPeiLib run early PEIM phase by LeviYeoReum ・ Pull Request #12096 ・ tianocore/edk2. I have the change in review in our repo but was hoping to get this merged into EDK2 instead and pull it down ASAP. This change is required to get our PeilessSec platform to work. It has been reviewed and approved by Levi and should be good to go. Please let me know if this is possible. Thank you! > > > > Raymond > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121800): https://edk2.groups.io/g/devel/message/121800 Mute This Topic: https://groups.io/mt/117665128/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
