This PR fails the path of least surprise quite badly. It "fixes" a PR that removed a DEPEX that was maintaining load order, and it does this by making the event handler function called when a protocol is available silently return in case the protocol was not in fact available.
This feels like a design issue that needs fixing, not a symptom that needs to be hidden a few days before a stable tag after being in the tree since September. Best Regards, Leif On Tue, 19 May 2026 at 14:16, Sami Mujawar <[email protected]> wrote: > Dear Tianocore Stewards, > > The PR https://github.com/tianocore/edk2/pull/12562 is an essential bug > fix and has been reviewed. > > I do not have access to set the milestone to edk2-stable202605. > > Is it possible to set the milestone and include this fix in the stable tag > edk2-stable202605, > please? > > Warm regards, > > Sami Mujawar > > *From: *Oleksandr Tymoshenko <[email protected]> > *Date: *Tuesday, 19 May 2026 at 00:05 > *To: *tianocore/edk2 <[email protected]> > *Cc: *Sami Mujawar <[email protected]>; Review requested < > [email protected]> > *Subject: *Re: [tianocore/edk2] DynamicTablesPkg: Fix dependency issues > with consumed protocols (PR #12562) > > *gonzoua* left a comment (tianocore/edk2#12562) > <https://github.com/tianocore/edk2/pull/12562?email_source=notifications&email_token=ACY3LHYWGCYAX4CSVHVY3YD43OJJ5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINBYGMYDANBUGU3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4483004456> > > Gentle reminder: I think this is a regression and should be fixed in > stable tag. > > — > Reply to this email directly, view it on GitHub > <https://github.com/tianocore/edk2/pull/12562?email_source=notifications&email_token=ACY3LHYWGCYAX4CSVHVY3YD43OJJ5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINBYGMYDANBUGU3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4483004456>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACY3LH6W56RYFM42C7QFEUD43OJJ5AVCNFSM6AAAAACYWUAVL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIOBTGAYDINBVGY> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or > Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> > . > You are receiving this because your review was requested. > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121960): https://edk2.groups.io/g/devel/message/121960 Mute This Topic: https://groups.io/mt/119390195/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
