Hi Pierre,

GitHub required write permissions to resolve a comment and there is no 
finer grain control over that specific action.

However, the PR author can always resolve a comment.

So a work around in the soft freeze is to add a comment to the thread 
tagging the PR author letting the PR author know that the issue is now
resolved and the PR author can now resolve the comment.  You can also 
tag Liming in the same comment so Liming knows the conversation can 
be resolved when evaluating which PRs are ready for `push` label.

Mike

> -----Original Message-----
> From: Pierre Gondois <[email protected]>
> Sent: Tuesday, November 3, 2026 2:08 AM
> To: [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; 'Andrew Fish' <[email protected]>;
> Kinney, Michael D <[email protected]>; 'Ard Biesheuvel'
> <[email protected]>; Kubacki, Michael <[email protected]>
> Subject: Re: [edk2-devel] Soft Feature Freeze starts now for edk2-
> stable202611
> 
> Hello Liming,
> 
> On 11/3/26 02:00, gaoliming via devel wrote:
> >
> > Hi, all
> >
> >   We enter into Soft Feature Freeze phase now. In this phase,
> >
> > the feature under review will not be allowed to be pushed. The
> feature
> >
> > passed review can still be merged.
> >
> >   The patch review can continue without break in edk2 community. If
> the
> >
> > patch is under review process, and plans to catch this stable tag,
> the
> >
> > patch contributor need to send the request in edk2 mail list. If the
> > patch
> >
> > is submitted after Soft Feature Freeze, and plans to catch this
> stable
> > tag,
> >
> > Please send the request in edk2 mail list and notify edk2 community,
> > so the
> >
> > community know this patch target and give the feedback.
> >
> >   To avoid the unnecessary changes to be merged in edk2 stable tag
> > release,
> >
> > all edk2 maintainers' write access will be temporarily disabled
> until
> > stable
> >
> > tag is released on 11-20. That means edk2 maintainer can't set push
> > label in
> >
> > pull request after soft feature freeze starts.
> >
> During the freeze period, it is not possible to "Resolve comment"
> anymore, this makes the review process a bit more difficult. Would it
> be possible to still have that possibility (even though the write
> access
> is removed) ?
> 
> Regards,
> 
> Pierre
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose
> the contents to any other person, use it for any purpose, or store or
> copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#122234): https://edk2.groups.io/g/devel/message/122234
Mute This Topic: https://groups.io/mt/122069712/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to