Hi Bruno,
where can we find this patch? The URL provided gives a 404 error.
Nisan
At 02:01 AM 8/8/01 +0100, Bruno David Sim�es Rodrigues wrote:
>Ok, people.
>
>I have a patch against 2001.08.08 CVS Version in
>http://litux.org/~bruno/kannel-patch.tar.gz.
>Could you please try it and comment it ?
>
>Changelog:
>2001-08-08 Bruno Rodrigues <[EMAIL PROTECTED]>
>
> * cfg.def,smsbox.c: Added reply-requestfailed to smsbox
> configuration;
> * cfg.def,smscconn_p.h,smscconn.c,smsc.c,smsc_p.h: Added
> allowed-prefix to smsc configuration;
> * cfg.def,smsbox.c: Added allowed/denied-prefix to sendsms-user
> configuration;
> * cfg.def,urltrans.[ch]: Added name field to sms-service and
> sendsms-user configuration, to be used on bearerbox_access log.
> * smsc_[cimd|cimd2|emi|fake|ois|sema|smpp].c,msg-decl.h: Replaced
> flag_8bit with mc, dc, mwi and compress, using fields_to_dcs and
> dcs_to_fields; Replaced flag_udh with octstr_len(udh) (udh should't
> be null any longer). Could someone check if everything is ok and
> implement the new functions on this modules ?
> * gw/smsc_[at|emi2|http].c: Same as other smsc's, but I'm testing
> everything exaustively
> * gw/smsc_emi2.c: wait for first -31 ack before entering
> sendsms_loop. We can test in here if -31 is not supported and
> switch to a -61 or something. Changed send keepalive/send message
> order in send_loop; corrected a small bug when using flow_control
> that caused a received message to stay in outgoing queue until
> another message arrives, when it was received when waiting for
> last ack.
> * gw/sms.[ch]: inplemented fields_to_dcs and dcs_to_fields: using
> sms.[dc|mc|mwi|compress] and len(sms.msgdata), returns the dcs
> acording to ETSI GSM 03.38 and vice-versa. Parameter mode selects
> from 0x0x or 0xFx encoding mode (example, in smsc_at.c, if modem
> is a siemens, uses mode 1)
> * gw/bb_smscconn.c: Added more information to bearerbox_access.log:
> Svc (http-service used), flags (dc,mc,mwi,compress), msg and udh
> length and full msg and udh dump (msg in hex if dc=8bit or UCS2 and
> udh in hex)
> * gw/bb_smscconn.c: Write a ack with nack bit on to store, so that
> the message would get out of queue. Someday when someone adds
> notify kind of message, add nack too.
> * gw/smsbox.c: permit empty messages (why not?)
> * gw/smsbox.c: added encoding field
>
>More Comments and questions:
> 1. in sms.c, I've implemented fields_to_dcs and vice-versa, to convert
>from (and to)
>mc (message class), dc (data coding), mwi (message waiting indicator) and
>compress
>to dcs. Could you please use it in smsc_*.c so every dcs combination is
>available on
>all smsc ?
> 2. I'm thinking in converting to GSM_alphabet and to UCS2 right in
>smsbox so the
>splitting code could be the same to all smsc. (or at least know how to split
>the data,
>even if we decide to pass UTF-8 to the smsc's)
> 3. in smsbox.c, line 1194, there's code to do encoding from http
>encoding field to
>ISO-8859-1 or UTF-16BE, but something is wrong. Could someone help me with
>it ?
>
>Tomorrow I'll add more comments and do some more testing.
>
>If you want to contact me, you could use Yahoo with davipt or MSN with
>davipt at hotmail
>
>--
>Bruno Rodrigues
