Don't send it to me - send it to the list :-) If I'm already forwarding stuff - I like the way Dennis fixed the time reading from the PDU ( I know I should have fixed it earlier, but I had other things on my mind ;-), so I ported it to AT2 on the CVS. I also changed the way he handles the time zone to get it to work. Now decode_deliver decodes time correctly, but I still get bogus time stamps with the messages - I guess it's date_convert_universal() fault's. l'll look into it next. All the patches below are Dennis Malmstrom's, except the smsc_at2 patch which is my own's. I hadn't managed to apply all of Dennis' patches, them being against 1.0.3 (Dennis - could you please try your changes on the CVS version ? patche 1.0.3 doesn't really help the development much..) but I like most of his chnages.
P.S.
Dennis - The current AT2 module have some comments about things that has
to do with Nokia 7110 - maybe you could try to use that with your Nokia
? Using AT2 is preferd over AT anyway.
Oded Arbel
m-Wise Inc.
[EMAIL PROTECTED]
--
I haven't failed, I've found 10,000 ways that don't work.
-- Ben Franklin
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Thursday, February 07, 2002 5:01 PM
To: Oded Arbel
Subject: RE: timestamps, scripts and nokia 7110
Ok, lets try it again.
/Dennis
-----Original Message-----
From: Oded Arbel [mailto:[EMAIL PROTECTED]]
Sent: Thu 2002-02-07 15:05
To: Malmstr�m, Dennis
Cc:
Subject: RE: timestamps, scripts and nokia 7110
Major oops :-) your patches are reversed - it's a patch of how to
downgrade from your changes back to the original..
Oded Arbel
m-Wise Inc.
[EMAIL PROTECTED]
--
Elwood: What kind of music do you get here ma'am?
Barmaid: Why, we get both kinds of music, Country and Western.
On Thu, 2002-02-07 at 15:17, "Malmstr�m, Dennis" wrote:
>
> Oops, I forgot to eclose the changes.
>
>
> /Dennis
>
>
> -----Original Message-----
> From: Malmstr�m, Dennis
> Sent: Thu 2002-02-07 14:01
> To: [EMAIL PROTECTED]
> Cc:
> Subject: timestamps, scripts and nokia 7110
>
> Hello
>
> I've been using kannel (version 1.0.3) to implement a prototype sms
gateway. This has required some changes to the source code. I case any
of them are of
> value to the kannel project I hereby submit them.
>
> Be aware that I have not gained overall understanding of the code.
The purpose of the changes have been to solve my particular problems as
quickly as
> possible. This should be taken into account when considering the
changes (no guarantees).
>
>
>
> The changes I made are:
>
> 1) Added three escape codes:
> %z, skips a word.
> %A, same as %a but without url encoding.
> %R, same as %r but without url encoding.
>
> 2) Added the possibility of executing a command line instead of
fetching an url.
> Configuration file example:
> group = sms-service
> keyword = default
> execute = <command line>
>
> 3) Added modemtype nokia7110.
> I started out using the modemtype premicell (which I somehow
gathered was nokia related).
> Getting it to work required a few changes to the GSM modem
handling code (gw/smsc_at.c).
> I created a new modemtype so I wouldn't change the definition of
an existing one.
>
> 4) Fixed broken timestamp parser.
> I am not sure wether this is a general issue or specific to nokia
7110.
> Anyway, the existing code produced nonsense values for the data
sent from a nokia 7110.
>
>
>
> The following source code files where changed:
>
> file change
> ---- ------
> gwlib/octstr.h
> gwlib/octstr.c Added function for reading Octstr from
FILE*. Used by gw/smsbox_req.c.
>
> gw/smsbox_req.c (2)
>
> gw/smsc_at.c (3)
> (4)
>
> gw/urltrans.c (1)
> (2)
>
>
> /Dennis
>
> Dennis Malmstr�m
> Erda Technology AB
> S:t Larsgatan 12, 582 24 Link�ping, Sweden
> http://www.erda.se
> mail: [EMAIL PROTECTED]
> phone: +46 (0)13 377218
> gsm: +46 (0)706483090
>
>
>
>
>
>
--
Oded Arbel
m-Wise inc.
[EMAIL PROTECTED]
--
Politicians are like diapers. They both need changing regularly and for
the same reason.
octstr.c.diff
Description: octstr.c.diff
octstr.h.diff
Description: octstr.h.diff
smsbox_req.c.diff
Description: smsbox_req.c.diff
smsc_at.c.diff
Description: smsc_at.c.diff
urltrans.c.diff
Description: urltrans.c.diff
smsc_at2.patch
Description: smsc_at2.patch
