Oops - had a small bug - fixed in this patch. sorry guys.
--
Oded Arbel
m-Wise Inc.
[EMAIL PROTECTED]
X windows:
A new level of software disintegration.
> -----Original Message-----
> From: Oded Arbel
> Sent: Sunday, March 17, 2002 6:00 PM
> To: Kannel-devel (E-mail)
> Subject: [Patch] Resubmit: Timestamp patch to AT2
>
>
> Hi list.
>
> I resubmit the timestamp patch to AT2 against current CVS snapshot - I
> tested it more throughly and found out that while it works
> correctly on
> parsing the time in the PDU (unlike the current implementation), I
> don't know how to parse the time zone data - on all the handsets I
> tested, the timestamp contains the handset's clock setting (even if
> different then the actual time) and the timezone set to GMT (which,
> since I'm not in GMT timezone, is false).
> I think that the correct behavior would be to apply the timezone entry
> in reverse - that is if it says GMT+3, then substruct 3 hours from the
> hour field. at least, the documentation I've read suggest that - so
> that's what the code says. please test this throughly.
>
> OTOH - even if the timezone parsing is incorrect, this code
> offers much
> improved PDU timestamp parsing over the current implimentation (which
> doesn't do much more then sort of a memcopy to the universtal time
> struct), and should be applied to the CVS.
>
> TIA
>
> --
> Oded Arbel
> m-Wise Inc.
> [EMAIL PROTECTED]
>
> Any clod can have the facts, but having opinions is an art.
> -- Charles McCabe
> <<smsc_at2.timestamp.patch>>
>
smsc_at2.timestamp.patch
Description: smsc_at2.timestamp.patch
