Hi list. Here are two patches that were useful to me, and I hope that will be considered for submission :
- HTTPS : I had a problem with a broken HTTPS server implementation (that I had to get Kannel to connect to), which sometimes would not complete the SSL handshake but will send a FIN packet in the middle of the setup. I've read something about it in OpenSSL documentation, but its said there that OpenSSL should detect this and return with an error. apparently (from many tests) this does not happen : when SSL_connect() gets that packet it just ignores it and continues to wait for the SSL handshake completion - which hangs for ever. The simple work around that I submit here will simply set the socket to non-blocking state early, and then loop around the SSL_connect() until it either succeeds in connecting or timesout. currently the timeout is hardcoded as 30 seconds (which I think should be reasonable for all purposes). I tried to look for a fast way to get it configurable, but didn't find any quick hack - so I left it be. - Billing : I needed to get a per message billing information into Kannel, so I added a "billing" parameter to the sendsms call and a billing integer to the SMS message data structure. this was really a search-and-replace kind of hack, into a code I don't fully understand, so I hope I didn't brake anything. Both patches are deployed and "works for me", and while I understand that those are not high priority problems for most users, I will be grateful if the patches are incorporated into the CVS (will save me work when I update from CVS ;-) Cheers -- Oded Arbel m-Wise Inc. [EMAIL PROTECTED] (972)-67-340014 (972)-9-9581711 (ext: 116) ::.. Juall's Law on Nice Guys: Nice guys don't always finish last; sometimes they don't finish. Sometimes they don't even get a chance to start! <<billing.patch>> <<https.patch>>
billing.patch
Description: billing.patch
https.patch
Description: https.patch
