Paul Keogh wrote:
>
> The accept_boxc() function mishandles denied IP connections. The
> code to handle a denied IP connection should be amended to;
>
> if (is_allowed_ip(box_allow_ip, box_deny_ip, ip) == 0) {
> info(0, "Box connection tried from denied host <%s>, disconnected",
> octstr_get_cstr(ip));
> octstr_destroy(ip);
> close (newfd);
> ^^^^^^^^^^^^^^ Add this line ^^^^^^^^^^
> return NULL;
> }
>
> so that the newfd socket descriptor is closed otherwise;
>
> * There is a resource leak
>
> * The remote client doesn't get a helpful ECONNRESET (?) error to let them
> something is wrong.
commited to cvs, thanks Paul.
Stipe
[EMAIL PROTECTED]
-------------------------------------------------------------------
Wapme Systems AG
M�nsterstr. 248
40470 D�sseldorf
Tel: +49-211-74845-0
Fax: +49-211-74845-299
E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are
