That looks like a major rewrite from Lars at Dec 21 2000, from
diffing 1.26 to 1.27 (1.23.2.3 is relative to another branch).
I don't see any unbind in 1.27 code, nor in a quick grep for unbind
and UNBIND in current cvs code.
Can anyone see if unbind pdu is needed and add the code please ?
I do already have a smpp account configured, but I have no time
to test it now :(
On Sat, 2002-06-08 at 02:30, Wayne wrote:
> Yes, the ViewCVS interface does offer this view of changes, but not why.
>
> Version 1.23.2.3 of smsc_smpp.c had this.......
>
> int smpp_close(SMSCenter *smsc) {
>
> struct smpp_pdu *pdu = NULL;
>
> debug("bb.sms.smpp", 0, "smpp_close: closing");
>
> /* Push a UNBIND PDU on the [smsc->fifo_r_out] stack. */
> pdu = pdu_new();
> if(pdu == NULL) goto error;
> pdu->id = SMPP_UNBIND;
> pdu->length = 16;
> pdu->status = 0;
> pdu->sequence_no = 1;
> pdu->message_body = NULL;
> fifo_push(smsc->fifo_r_out, pdu);
> .......
> .......
> }
>
>
> Version 1.27 of smsc_smpp.c had this.......
>
> /* XXX write out unbind pdus at quit time */
>
> int smpp_close(SMSCenter *smsc)
> {
> smpp_quit(smsc->smpp);
> smpp_destroy(smsc->smpp);
> smscenter_destruct(smsc);
> return 0;
> }
>
>
> No reason given.
>
> So my question still stands.....
>
> Was this replaced with something else ?
>
> I need to send an unbind notification to a SMSC, the SMSC provider is
> stating that an unbind is part of the SMPP standard.
>
> Wayne
>
> -----Original Message-----
> From: Stipe Tolj [mailto:[EMAIL PROTECTED]]
> Sent: Friday, 7 June 2002 6:32 PM
> To: Wayne Smithers
> Cc: [EMAIL PROTECTED]
> Subject: Re: smpp unbind
>
> Wayne Smithers wrote:
> >
> > What happened to this code from 1.0.3 in 1.1.6
> >
> > smsc_smpp.c: /* Push a UNBIND PDU on the [smsc->fifo_r_out] stack.
> */
> > smsc_smpp.c: pdu->id = SMPP_UNBIND;
> > smsc_smpp.c: /* Push a UNBIND PDU on the [smsc->fifo_t_out] stack.
> */
> > smsc_smpp.c: pdu->id = SMPP_UNBIND;
> > smsc_smpp.c: /* Write out the UNBIND PDUs. */
> > smsc_smpp.c: /* If states are BOUND then push UNBIND messages to
> > smsc_smpp.c: case SMPP_UNBIND_RESP:
> > smsc_smpp.c: case SMPP_UNBIND_RESP:
> > smsc_smpp.c: case SMPP_UNBIND_RESP:
> > smsc_smpp.c: case SMPP_UNBIND:
> > smsc_smpp.c: case SMPP_UNBIND_RESP:
> > smsc_smpp.c:* UNBIND, UNBIND_RESP
> > smsc_smpp.h:#define SMPP_UNBIND 0x00000006
> > smsc_smpp.h:#define SMPP_UNBIND_RESP 0x80000006
> >
> > Was this replaced with something else ?
> >
> > I need to send an unbind notification to a SMSC which was done by
> default in
> > 1.0.3 when certain signals were received by the bearerbox process.
> > In the dev version 1.1.5 & 1.1.6 the connection is just terminated, no
> > unbind is sent.
>
> please use our ViewCVS interface to figure out who changes the unbind
> behaviour any hopefully also why.
>
> Stipe
>
> [EMAIL PROTECTED]
> -------------------------------------------------------------------
> Wapme Systems AG
>
> Vogelsanger Weg 80
> 40470 D�sseldorf
>
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
>
> E-Mail: [EMAIL PROTECTED]
> Internet: http://www.wapme-systems.de
> -------------------------------------------------------------------
> wapme.net - wherever you are
>
>
