Hi Oded, Good catch.
Forgive if I sound stupid, but regarding the length of an address. If it is really bigger then 20 can one just discard the part of the address that is longer?? That sounds weird to me, or is the address only used internal in the smpp part as some indication?? On top of your patch, would it not be better to have the length of an address in some #define and use that?? Then changing the length is done in one place only. --On Sunday, August 11, 2002 1:00 PM +0300 Oded Arbel <[EMAIL PROTECTED]> wrote: > Hi list > > We encountered a bug that causes SMPP to panic when creating the PDU if > the receiver or sender address is longer then 20 characters. the panic > occures in smpp_pdu.c in smpp_pdu_pack which asserts on the length of the > source Octstr before packing it into the PDU. I don't want to change the > assert, just make sure that it will not be invoked just because the user > enetered bad data, so attached is this patch. Harrie Internet Management Consulting mailto:[EMAIL PROTECTED] http ://www.mod-snmp.com/ ------------------------------------------------------------------- Author of MOD-SNMP, enabling SNMP management to the Apache server.
