Benjamin Lee wrote: > > Using CVS version of kannel (updated a few minutes ago)... > > We found that the SMPP smsc module did not correctly charset encode a long > text message that was automatically split by kannel / smsbox according to: > > concatenation = yes > > At a glance, I do not think this code rearrangement should have any adverse > effects, except if msg->SMS.msgdata is presumed to be exactly what the user > sent in later on in code (because this patch will charset encode the user's > data in place -- which could be considered bad behaviour). > > Find patch attached anyway. Comments?
you moved the if statement block out of the udhdata condition check, which means then, that even messages that contain udhdata will be encoded. Hmm, is that considered to be a right behaviour? Ahh, ok, got it. If you send a "too long" message and smsbox splits it to multiple msg chunks, then the single msgs contain udhdata (the split information) and hence the msgdata will not be encoded. Right?! Ok, this can be considered a missbehaviour. I'll vote +1 for changing this. But I'd like to avoid the "inplace-change" of the msg structure. That should be changed. Stipe [EMAIL PROTECTED] ------------------------------------------------------------------- Wapme Systems AG Vogelsanger Weg 80 40470 D�sseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are
