On Friday, March 7, 2003, at 02:28 PM, Bruno David Rodrigues wrote:


Citando Stipe Tolj <[EMAIL PROTECTED]>:

Bruno David Rodrigues wrote:

As you've commited your fix to cvs before sending me this email, I'll leave
it
to you the job to fix your both bugs ;)

come on Bruno. I just fixed the situation temporarly as a kludge ;)


How should be proceed here?!

:)


I think Bas Schulte is right - second parse_url is not needed. Can you please
remove it and test if it works ok ?

Only problem is that send_request is called from two places: from handle_transaction as well as from write_request_thread.


In write_request_thread, get_connection is called which in turn calls parse_url, so this case seems to be ok. However, in handle_transaction, there's no call to get_connection, it only calls send_request. In this case, parse_url might never have taken place so the username/password etc. might not have been set in the trans structure.

Funny thing is that I can't find what piece of Kannel is calling handle_transaction. I have a suspicion it's never called/used, may be it's an historic left-over?

I'll do a test with removing the call to parse_url in send_request, see what happens.



Reply via email to