>>
>> Attached an simple patch to fix a typo in the EMI2 driver, related
>> to wait-ack-expire behaviour.
>
>Angel, thanks for the patch.
>
>Can you please comment why this is a typo or any other please vote if
>this is a fix?!
>
This is from the user-guide:
wait-ack-expire
Defines what kind of action should be taken if the the ack of
a message expires. The options for this value are:
0x00 - disconnect/reconnect, (default) 0x01 - as is now, requeue,
but this could potentially result in the msg arriving twice
0x02 - just carry on waiting (given that the wait-ack should never
expire this is the mst accurate)
And this is from the driver:
} else if (PRIVDATA(conn)->waitack_expire == 0x03) {
// 0x02 - carry on waiting
warning(0, "EMI2[%s]: received neither ACK nor NACK for message %d "
"in %d seconds, carrying on waiting",
octstr_get_cstr(privdata->name),
i, PRIVDATA(conn)->waitack);
}
The documentation and source code comments gives a 0x02 value,
but the actual source code is comparing against 0x03.
Hope this clarifies.
Angel Fradejas
Mediafusi�n Espa�a, S.A.
[EMAIL PROTECTED]
www.mediafusion.es
Tel. +34 91 252 32 00
Fax +34 91 572 27 08
