tirsdag 28. oktober 2003, 14:20, skrev Alexander Malysh:
> Hi,
>
> I'm -1 for change of shared.c... sorry but it will not work for at least
> smpp module...
Why?
Now that Kannel has support for billing, there should be a policy of how to
handle this problem of billing mulitpart messages. As implementations may
vary across operator, could perhaps a configuration parameter solve it?
Something like bill-first=yes|now. If bill-first=yes then my patch or
something similar could be used.
> CIMD2 patch look good, but see below ... Unfortunately we don't have any
> cimd connections there so can't test it :(
>
> @@ -2034,11 +2046,14 @@
> default:
> code = 0;
> }
> + if (st_ecode > 0)
> + code = st_ecode;
>
> I believe that this will not work?! here code is a kannel's dlr-mask, see
> sms.h or are kannel's dlr-mask and st_ecode equal?
It does work for us. We now receive the errorcode when it greater than zero,
otherwise we receive Kannels usual status code.
> if(code)
> msg = dlr_find(conn->name, timestamp, destination, code);
> else
> msg = NULL;
>
>
> On Tuesday 28 October 2003 13:40, Arne K. Haaje wrote:
>
> [snip]
>
> > Attached is a patch for smsc_cimd2.c that set field 64 Tariff Class to
> > the value of binfo if binfo is set.
> >
> > I have also updated smsc_cimd2.c to set field 55 Reply Path to enabled if
> > rpi is set.
> >
> > These two changes should make the CIMD2 module more up to date, but my
> > final change to smsc_cimd2.c may be more controversial.
> >
> > There is an integer field in the CIMD2 protocol called 62 Status Error
> > Code that can provide more detail about why a message was not delivered.
> > When doing MT billing it is necessesary to know if a message failed
> > because it belonged to an other operator (ported), or if a prepaid card
> > had no balance.
> >
> > I have altered smsc_cimd2.c to send this error code instead of the usual
> > if it is set. If you feel this is not the way to do it then feel free to
> > rip it out if you apply the rest of the patch.
> >
> > I have also made a change to shared.c that may be a bit controversial.
> > For multipart messages like picturemessages, I have altered shared.c to
> > only set binfo for the first part. This is to avoid double of triple
> > charging the customer! The CIMD2 protocol says nothing about this issue,
> > but the two operators we use CIMD2 with, want it that way. However, it
> > may perhaps not work with other modules.
> >
> > We run this patched code against two operator, and have had no problem
> > with it.
> >
> > Please discuss and vote.
--
Med vennlig hilsen,
Eurobate ASA
Arne K. Haaje
Senior Network Engineer
--------------------------------------------------------------------
Eurobate ASA - Postboks 4589 Nydalen - 0404 Oslo - Norway
Phone: +47 23 22 73 73 - Fax: +47 23 22 73 74 - Mob: +47 92 88 44 66
http://www.eurobate.com/
