Replying to Stipe Tolj: > can you point out what the patch actually fixes/solves/does better, > please?! Of course we will be able to "come thought this". But it > makes things easier if you shade the light directly to our eyes ;)
Ok. 1st. """ if ((charset = find_charset_encoding(content.body)) == NULL) """ These lines in original code anticipate charset clause in xml source but don't pay attention to charset clause in headers. When web server doing charset on the fly recoding, it usually places actual content encoding in headers, don't modifying body other way than recoding. Ok, back to the add_charset stuff. For some reason it adds all charset libxml can handle to Accept-Charset. I didn't investigated this thoroughly yet but it seems that it acrually does improper recoding. Octet dumps of compiled wmls seems that strings are passed to device with for example iso-8859-5 encoding which is added by add_charset_headers but NOT accepted by device. Also, device_headers check for acceptance of utf encoding is somewhat bogus, because it checks false when I test. So I decided to rip off these stuff completely, and for now set preferred way of xml and further utf-8. Of course, this is quick-and-dirty bandaid, that's why I wrapped it with ifdefs. But it actually solves my problems here. And from the logical point of view it should be much clearer than what was before. I often hit problems with charset, just because our intended audience are russian natives. And I will continue to work on this issue. -- Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key This message represents the official view of the voices in my head
