Hi,

please note, that dlr support for postgresql was commited by me and as
stated on the ML was not stress tested!


Alan McNatty wrote:

> I agree completely - just highlighting for Bruno.
> 
> If he's going to make a Debian package for stable it will be an issue if
> package has is compiled --with-pgsql and as long as 7.2 is in stable.
> 
> On Fri, 2004-08-06 at 10:04, Pedro B. wrote:
>> Sorry, but doing patches to support a 7.2.x version when 7.4.x is the
>> stable version, is like proposing to go back to stoneage and make fire
>> by using 2 sticks.
>> 
>> The 7.2 is completely deprecated on a postgres point of view.
>> 
>> I do know debian-stable still uses it, but it shouldn't. 7.4.3 should
>> have gone out of testing ages ago. 7.5 is halfway under development,
>> because everyone in the "postgres world" (hate these tags, but they are
>> sometimes needed) has implemented 7.4.
>> 
>> These are the 2 cents from a deep-into-postgres-point of view.
>> 
>> \\pb
>> 
>> 
>> 
>> 
>> Alan McNatty wrote:
>> 
>> > Hi Bruno,
>> > 
>> > I've tested the pgsql dlr storage on 7.2.1 (debian stable) but found
>> > that Kannel utilised a DELETE ... LIMIT 1 in dlr_pgsql_remove from
>> > gw/dlr_pgsql.c which is not supported in 7.2.1.
>> > 
>> > ERROR: PGSQL: DELETE FROM dlr WHERE smsc='foo' AND ts='243251116' LIMIT
>> > 1;
>> > ERROR: PGSQL: ERROR:  parser: parse error at or near "LIMIT"
>> > ERROR: PGSQL: DB update failed!
>> > 
>> > For postgres stable you may want to change from ...
>> > 
>> > DELETE FROM a WHERE b=3 LIMIT 1;
>> > 
>> > - to -
>> > 
>> > DELETE FROM a WHERE ctid=(SELECT ctid FROM a WHERE b=3 LIMIT 1);
>> > 
>> > Can supply a patch if required.
>> > 
>> > Cheers,
>> > Alan
>> > 
>> > 
>> > On Fri, 2004-08-06 at 01:09, Bruno Rodrigues wrote:
>> > 
>> >>Alexander Malysh wrote:
>> >>
>> >>
>> >>>hmm, ok - understand... looking through bug reports, I don't see any
>> >>>showstopper to call 1.3.2 -> 1.2.2 (anyway 1.3.2 is more stable as
>> >>>1.2.1), so I'm +1.
>> >>
>> >>Everybody else, "please vote now or shutup forever" ;) (how is it the
>> >>setence when you marry, in english ?)
>> >>
>> >>
>> >>>btw. copyright in debian directory doesn't match kannel license...
>> >>
>> >>Indeed. I haven't had time to update any debian stuff for too much
>> >>time.
>> >>  I'll check everything and post it on my site and kannel before I try
>> >>to upload to Debian. Hopefully, still this evening.
>> >>
>> >>
>> >>
>> > 
>> > 
>> > 
>> > 
>> 
>>

-- 
Thanks,
Alex


Reply via email to