Jonathan Houser wrote:
Thanks to Dermot and Paul for their feedback. I actually made a patch that fixes my issue with a lot less code changes than what Paul had submitted. Essentially the issue was that the charset was being changed, but the actual low-level compiler didn't know this and instead used the charset defined in the <?xml...encoding=... block. All I did was add a flag, "was_converted", to the content struct. I then set it to 1 if it's been converted, and use it in the compiler itself to see that it should prefer the passed in charset over the one in the <?xml block. Simple fix. Works for me. I'm going to have to back out my changes for the other patch (http-proxy-port-exceptions) if the core developers feel I should. Then I'll submit this patch and re-code the fix for my other issue.
hmm, this charset handling issue is really doing mad... we did consider this already in a very early stage. Unfortunatly I don't recall it anymore in it's details. As I reviewed Paul's patch some time ago, I found myself again in the middle of that material and realized from reviewing the current code that I considered these issues. Now you guys come-up again with it ;)
I really need some "dummy way" to make it clear to me, sorry. Brain is definetly starting to swap.
Stipe
mailto:stolj_{at}_wapme.de ------------------------------------------------------------------- Wapme Systems AG
Vogelsanger Weg 80 40470 D�sseldorf, NRW, Germany
phone: +49.211.74845.0 fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de http://www.wapme-systems.de/ -------------------------------------------------------------------
