Re: [PATCH] SQLBOX Delivery Reports Insert

[Mi Reflejo]

You can filter out dlr by sms_type with a statement like (..)WHERE sms_type=3; if you want to keep delivery reports for any reason so i suggest to ignore "ACK/" messages that bearerbox sends. These kind of msg are useless.

I'm attaching my suggested patch. (Tested and working)

And of course if the table already exists you must to do: alter table sent_sms modify  momt enum('MO','MT','DLR');

Regards,
Martin

On 5/18/06, Rene Kluwen <[EMAIL PROTECTED]> wrote:

Maybe we should better introduce another type, besides MT & MO (e.g. DR for
Delivery Report)?
This way delivery reports can be filtered out with ease by constructing a
proper SQL statement.

The reasons that I would prefer this way are:
1. Backwards compatibility, and
2. Some people are counting on delivery reports being inserted. They are not
in all cases completely "unneccesary".

Another idea is to make this behaviour configurable.

Comments?

Rene Kluwen
Chimit


-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] ]On
Behalf Of Mi Reflejo
Sent: zaterdag 13 mei 2006 14:24
To: devel@kannel.org
Subject: [PATCH] SQLBOX Delivery Reports Insert


*gw/sqlbox.c
-Removed unnecessary INSERT's into database.
bearerbox_to_smsbox shouldn't INSERT delivery reports as type "MO".
condition added to discard delivery reports.

delivery_logtable_fix.patch
Description: Binary data