just read the original patch and I have two questions:
a) why is this line there:
http_header_remove_all(push_headers, "X-Kannel-From");
as the header is passed on as pointer, I don't see why it should
remove something from it.
b) it should also support passing &from=... in the URL, not just the
X-Kannel-Header.
Otherwhise I don't see anything wrong with adding it.
On 17.11.2006, at 15:07, Juan Nin wrote:
Hi!
As Stipe stated, here's my review of the Wap Push sender patch.
The patch was provided by Noor Entertainment here:
http://www.kannel.org/pipermail/devel/2006-July/000069.html
We've been using it for several weeks, and everyhting is working
great!!!
We've had no problem with it, the sender gets defined with the X-
Kannel-Sender header, and users get their Wap Push received with
the correct short code, instead of the default 1234.
I think this patch is a MUST to be added to Kannel CVS, since it's
working fine, and there's no sense on having to send Wap Pushes
with a default 1234, instead of the desired one. Moreover, many
carriers don't accept the Wap Push if you don't send them with a
valid sender for your connection...
Here I provide a log dump where sending a Wap Push with the sender
2888 using this patch, I'm not sure if there's anything else I can
provide for more info....
I'd like to hear comments on this, if it's candidate to be added to
CVS, if it will be added, or what else is needed...
Thanks for all the great job!!!
Here's the dump:
2006-11-17 00:03:07 [8226] [7] DEBUG: SMPP[bb-6-1]: Sending PDU:
2006-11-17 00:03:07 [8226] [7] DEBUG: SMPP PDU 0x45b00e78 dump:
2006-11-17 00:03:07 [8226] [7] DEBUG: type_name: deliver_sm_resp
2006-11-17 00:03:07 [8226] [7] DEBUG: command_id: 2147483653 =
0x80000005
2006-11-17 00:03:07 [8226] [7] DEBUG: command_status: 0 = 0x00000000
2006-11-17 00:03:07 [8226] [7] DEBUG: sequence_number: 168618 =
0x000292aa
2006-11-17 00:03:07 [8226] [7] DEBUG: message_id: NULL
2006-11-17 00:03:07 [8226] [7] DEBUG: SMPP PDU dump ends.
2006-11-17 00:03:07 [8226] [7] DEBUG: SMPP[bb-6-1]: Manually forced
source addr ton = 4, source add npi = 9
2006-11-17 00:03:07 [8226] [7] DEBUG: SMPP[bb-6-1]: Manually forced
dest addr ton = 1, dest add npi = 1
2006-11-17 00:03:07 [8226] [7] DEBUG: SMPP[bb-6-1]: Sending PDU:
2006-11-17 00:03:07 [8226] [7] DEBUG: SMPP PDU 0x45b01218 dump:
2006-11-17 00:03:07 [8226] [7] DEBUG: type_name: submit_sm
2006-11-17 00:03:07 [8226] [7] DEBUG: command_id: 4 = 0x00000004
2006-11-17 00:03:07 [8226] [7] DEBUG: command_status: 0 = 0x00000000
2006-11-17 00:03:07 [8226] [7] DEBUG: sequence_number: 1512 =
0x000005e8
2006-11-17 00:03:07 [8226] [7] DEBUG: service_type: NULL
2006-11-17 00:03:07 [8226] [7] DEBUG: source_addr_ton: 4 =
0x00000004
2006-11-17 00:03:07 [8226] [7] DEBUG: source_addr_npi: 9 =
0x00000009
2006-11-17 00:03:07 [8226] [7] DEBUG: source_addr: "2888"
2006-11-17 00:03:07 [8226] [7] DEBUG: dest_addr_ton: 1 = 0x00000001
2006-11-17 00:03:07 [8226] [7] DEBUG: dest_addr_npi: 1 = 0x00000001
2006-11-17 00:03:07 [8226] [7] DEBUG: destination_addr:
"50764550215"
2006-11-17 00:03:07 [8226] [7] DEBUG: esm_class: 64 = 0x00000040
2006-11-17 00:03:07 [8226] [7] DEBUG: protocol_id: 0 = 0x00000000
2006-11-17 00:03:07 [8226] [7] DEBUG: priority_flag: 0 = 0x00000000
2006-11-17 00:03:07 [8226] [7] DEBUG: schedule_delivery_time: NULL
2006-11-17 00:03:07 [8226] [7] DEBUG: validity_period:
"061118060307000+"
2006-11-17 00:03:07 [8226] [7] DEBUG: registered_delivery: 0 =
0x00000000
2006-11-17 00:03:07 [8226] [7] DEBUG: replace_if_present_flag: 0
= 0x00000000
2006-11-17 00:03:07 [8226] [7] DEBUG: data_coding: 4 = 0x00000004
2006-11-17 00:03:07 [8226] [7] DEBUG: sm_default_msg_id: 0 =
0x00000000
2006-11-17 00:03:07 [8226] [7] DEBUG: sm_length: 117 = 0x00000075
2006-11-17 00:03:07 [8226] [7] DEBUG: short_message:
2006-11-17 00:03:07 [8226] [7] DEBUG: Octet string at 0x45b01078:
2006-11-17 00:03:07 [8226] [7] DEBUG: len: 117
2006-11-17 00:03:07 [8226] [7] DEBUG: size: 1024
2006-11-17 00:03:07 [8226] [7] DEBUG: immutable: 0
2006-11-17 00:03:07 [8226] [7] DEBUG: data: 06 05 04 0b 84 23
f0 c9 06 05 ae 8d e6 c3 93 02 .....#..........
2006-11-17 00:03:07 [8226] [7] DEBUG: data: 05 6a 00 45 c6 08
11 03 42 69 6e 62 69 74 5f 35 .j.E....Binbit_5
2006-11-17 00:03:07 [8226] [7] DEBUG: data: 30 37 36 34 35 35
30 32 31 35 5f 32 30 30 36 31 0764550215_20061
2006-11-17 00:03:07 [8226] [7] DEBUG: data: 31 31 37 30 30 30
33 30 37 00 0c 03 77 61 70 2e 117000307...wap.
2006-11-17 00:03:07 [8226] [7] DEBUG: data: 62 69 6e 62 69 74
00 85 03 63 6e 74 2e 70 68 70 binbit...cnt.php
2006-11-17 00:03:07 [8226] [7] DEBUG: data: 2f 36 34 33 33 38
37 34 31 39 31 37 37 30 00 01 /6433874191770..
2006-11-17 00:03:07 [8226] [7] DEBUG: data: 03 44 65 73 63 61
72 67 61 20 74 75 20 46 6f 6e .Descarga tu Fon
2006-11-17 00:03:07 [8226] [7] DEBUG: data: 64 6f 00 01
01 do...
2006-11-17 00:03:07 [8226] [7] DEBUG: Octet string dump ends.
2006-11-17 00:03:07 [8226] [7] DEBUG: SMPP PDU dump ends.
2006-11-17 00:03:08 [8226] [7] DEBUG: SMPP[bb-6-1]: Got PDU:
2006-11-17 00:03:08 [8226] [7] DEBUG: SMPP PDU 0x45b01218 dump:
2006-11-17 00:03:08 [8226] [7] DEBUG: type_name: submit_sm_resp
2006-11-17 00:03:08 [8226] [7] DEBUG: command_id: 2147483652 =
0x80000004
2006-11-17 00:03:08 [8226] [7] DEBUG: command_status: 0 = 0x00000000
2006-11-17 00:03:08 [8226] [7] DEBUG: sequence_number: 1512 =
0x000005e8
2006-11-17 00:03:08 [8226] [7] DEBUG: message_id: "167d3"
2006-11-17 00:03:08 [8226] [7] DEBUG: SMPP PDU dump ends.
2006-11-17 00:03:29 [8226] [7] DEBUG: SMPP[bb-6-1]: Sending enquire
link:
2006-11-17 00:03:29 [8226] [7] DEBUG: SMPP PDU 0x45b01218 dump:
2006-11-17 00:03:29 [8226] [7] DEBUG: type_name: enquire_link
2006-11-17 00:03:29 [8226] [7] DEBUG: command_id: 21 = 0x00000015
2006-11-17 00:03:29 [8226] [7] DEBUG: command_status: 0 = 0x00000000
2006-11-17 00:03:29 [8226] [7] DEBUG: sequence_number: 1513 =
0x000005e9
2006-11-17 00:03:29 [8226] [7] DEBUG: SMPP PDU dump ends.
Regards,
Juan
-----Original Message-----
From: Stipe Tolj [mailto:[EMAIL PROTECTED]
Sent: 15 November 2006 01:23
To: [EMAIL PROTECTED]
Cc: Juan Nin; Kannel Devel
Subject: Re: patch for setting the sender in Wap Push
Hillel wrote:
> Hi Juan,
>
> I emailed the devel list and Stripe a few days ago on this. It
seems strange
> useful patches such as the patch for setting the sender in Wap
Push is not
> included in CVS? I wish Stripe would explain why some very
useful patches
> seem to get "ignored".
> I hope the patch for setting the sender in Wap Push will be
included very
> soon. Maybe Stripe will explain?
there is no ingnoration by us... it's mostly that people don't
have time to review.
We ENCOURAGE STRONGLY also others then Alex, Andreas, me, Vinc,
Martin to review
and quote a vote cvs commitment.
Stipe
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany
tolj.org system architecture Kannel Software Foundation (KSF)
http://www.tolj.org/ http://www.kannel.org/
mailto:st_{at}_tolj.org mailto: stolj_{at}_kannel.org
-------------------------------------------------------------------
