Hi Stripe, Thanks for adding in the patch.
Christian Noor Entertainment <[EMAIL PROTECTED]> on the Mon, 20 Nov 2006 asked the following question below and I wondered if his patch needs to be improved or is fine as is? "Hello all, Please find below clarifications regarding the wap push sender patch questions raised at http://www.kannel.org/pipermail/devel/2006-November/000587.html > a) why is this line there: > http_header_remove_all(push_headers, "X-Kannel-From"); > as the header is passed on as pointer, I don't see why it should remove something from it. I can only clarify why I put the line there. I noticed that the http_header_remove_all is called for all other X-Kannel headers in 'remove_x_kannel_headers'. I thought the same should be done for the new 'X-Kannel-From' header. And I did not add that to the 'remove_x_kannel_headers' because the 'X-Kannel-From' header is inspected through calling the 'handle_push_message' which comes two lines _after_ calling 'remove_x_kannel_headers' in the 'pap_request_thread' function. If you'd be able to clarify how this should be done, I probably should be able to fix this. " > -----Original Message----- > From: Stipe Tolj [mailto:[EMAIL PROTECTED] > Sent: 03 December 2006 01:08 > To: [EMAIL PROTECTED] > Cc: Kannel Devel > Subject: Re: please confirm the patch has been added > > > Hillel wrote: > > > Hi Stripe, > > > > Has the patch been added from Christian Noor Entertainment > > [EMAIL PROTECTED] on setting the Wap Push sender, > sent on the > > Date: Wed, 12 Jul 2006 02:35:43 ? > > > > It would be useful to have this included. > > sorry for the delay: > > yep, has been applied to cvs: > > 2006-11-17 Stipe Tolj <stolj at kannel.org> > * gw/wap_push_ppg.c: adding support to pass the 'from' > source addr via > X-Kannel-From HTTP header in the PPG request. > Thanks to Christian Boustany <[EMAIL PROTECTED]> > for this patch. > > > Stipe > > ------------------------------------------------------------------- > Kölner Landstrasse 419 > 40589 Düsseldorf, NRW, Germany > > tolj.org system architecture Kannel Software Foundation (KSF) > http://www.tolj.org/ http://www.kannel.org/ > > mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org > ------------------------------------------------------------------- > >
