> -----Original Message-----
> From: Andreas Fink [mailto:[EMAIL PROTECTED]
> Sent: 01 July 2008 11:34
> 
> On 01.07.2008, at 11:16, Bostock James wrote:
> 
> > --- gateway-1.4.1.orig/gw/smsc/smsc_soap.c      2005-09-19
> > 23:07:33.000000000 +0100
> > +++ gateway-1.4.1.gcc/gw/smsc/smsc_soap.c       2008-07-01
> > 09:20:56.000000000 +0100
> > @@ -223,7 +223,9 @@
> > /* useful macros go here (some of these were ripped of other
modules,
> >    so maybe its better to put them in a shared file) */
> > #define        O_DESTROY(a)    { if(a) octstr_destroy(a); a=NULL; }
> > +#if !defined(__64BIT__)
> > typedef long long int64;
> > +#endif
> 
> 
> wouldn't the following be more appropriate:
> 
> #if !defined(int64)
> typedef int64_t int64
> #endif
> 
> 

I am not sure what the best solution is. I wasn't actually suggesting
that my change be used (maybe I should have used a stronger term than
"questionable"). I just wanted to point out that there was a problem.

-james


Reply via email to