> From: Stipe Tolj > Sent: 10 July 2008 17:06 > > Bostock James schrieb: > > Hi, > > > > The attached patch causes the int64 type to only be defined (in > > gw/smsc/smsc_soap.c) if it does not already exist (as determined by the > > autoconf AC_CHECK_TYPES macro). This patch fixes a compilation failure > > on AIX when compiling in 64 bit mode. > > first of all thanks a lot James, we appreciate your work highly. > > hmmm, -0 on the patch. Reason: I don't like the idea to have > > #define HAVE_<TYPE> > > statements in the gw-config.h.in autoconf macro. >
It might be overkill but one option would be to add a separate header file in the gw/smsc directory with the #define HAVE_<TYPE>. Something similar has already been done in gwlib (gw_uuid_types.h.in). Or maybe the __s64 type defined in gw_uuid_types.h could be used. I am not sure how portable using int64_t is, otherwise I would suggest that. Comments? -james
