Hi Ben,

I was just too lazy as I implemented this part :)

The proper fix is to store List in the dict and then pick random box
after lookup.

Huh and you spotted real bug that we loop over the whole smsbox list. We should just pick the first that has queue not exceeded.
Something like attached patch.

Thanks,
Alex

Attached is a patch to sort the multiple boxes with the same name routing issue, I also added some code to do as Alex said about picking the first random un-named box thats not full, instead of looping through each box. Thats done basically the same as Alex's single line break addition, but I was able to remove a few unused variables as well.

I also corrected a few bits of bad indentation in the routing function whilst I was there.

Regards

Ben

Attachment: multi_smsboxid_routing.patch
Description: Binary data


Reply via email to