Re: Stable release 1.4.2 won't run on 64 bit

[Alexander Malysh]

Hi Alvaro,

if you use SMPP with DLRs then yes, this patch should fix it.

Alvaro Cornejo schrieb:

Hi

Can it also be related to this error I reported?

2009-01-20 00:27:14 [8890] [6] PANIC: octstr_format format string syntax
error.
2009-01-20 00:27:14 [8890] [6] PANIC:
/usr/local/sbin/bearerbox(gw_panic+0xc2) [0x80ce3a2]
2009-01-20 00:27:14 [8890] [6] PANIC:
/usr/local/sbin/bearerbox(octstr_format_valist_real+0x1a8) [0x80d2518]
2009-01-20 00:27:14 [8890] [6] PANIC:
/usr/local/sbin/bearerbox(octstr_format+0x1b) [0x80d2e5b]
2009-01-20 00:27:14 [8890] [6] PANIC: /usr/local/sbin/bearerbox
[0x808844c]
2009-01-20 00:27:14 [8890] [6] PANIC: /usr/local/sbin/bearerbox
[0x8089420]
2009-01-20 00:27:14 [8890] [6] PANIC: /usr/local/sbin/bearerbox
[0x808ad59]
2009-01-20 00:27:14 [8890] [6] PANIC: /usr/local/sbin/bearerbox
[0x80c4c31]
2009-01-20 00:27:14 [8890] [6] PANIC: /lib/libpthread.so.0 [0x4c83db]
2009-01-20 00:27:14 [8890] [6] PANIC: /lib/libc.so.6(clone+0x5e)
[0x5a726e]

Regards

Alvaro


On Wed, 2009-01-21 at 14:59 +0100, Alexander Malysh wrote:

Hi,

yep, great... pleas try attached patch on top of 1.4.2

Thanks,
Alex

Arne K. Haaje schrieb:

Onsdag 21 januar 2009 14:26:31 skrev Alexander Malysh:

Hi,

could you please run:

addr2line -e /path/to/64bit/compiled/bearerbox 0x448c31 0x449348
0x44a49b 0x4968b9

This was probably for Hillel, but I ran it as well for our own panics;

2009-01-21 11:51:05 [25065] [7] DEBUG: SMPP[xxxxx] handle_pdu, got DLR
2009-01-21 11:51:05 [25065] [7] PANIC: octstr_format format string syntax
error.
2009-01-21 11:51:05 [25065] [7] PANIC: bearerbox(gw_panic+0x10d) [0x4796ad]
2009-01-21 11:51:05 [25065] [7] PANIC:
bearerbox(octstr_format_valist_real+0x1b2) [0x47f602]
2009-01-21 11:51:05 [25065] [7] PANIC: bearerbox(octstr_format+0x8b)
[0x47fe8b]
2009-01-21 11:51:05 [25065] [7] PANIC: bearerbox [0x43a8f7]
2009-01-21 11:51:05 [25065] [7] PANIC: bearerbox [0x43b7b2]
2009-01-21 11:51:05 [25065] [7] PANIC: bearerbox [0x43c2b4]
2009-01-21 11:51:05 [25065] [7] PANIC: bearerbox [0x4710c5]
2009-01-21 11:51:05 [25065] [7] PANIC: /lib64/tls/libpthread.so.0

addr2line -e sbin/bearerbox 0x43a8f7 0x43b7b2 0x43c2b4 0x4710c5
/usr/include/stdlib.h:378
gw/smsc/smsc_smpp.c:1424
gw/smsc/smsc_smpp.c:1815
gwlib/gwthread-pthread.c:135

plain text document attachment (smpp.patch)
--- gw/smsc/smsc_smpp.c.orig    2009-01-21 14:55:38.000000000 +0100
+++ gw/smsc/smsc_smpp.c 2009-01-21 14:55:51.000000000 +0100
@@ -1278,9 +1278,9 @@
         } else {

if ((smpp->smpp_msg_id_type & 0x02) || (!octstr_check_range(msgid, 0, octstr_len(msgid), gw_isdigit))) {

-                tmp = octstr_format("%llu", strtoll(octstr_get_cstr(msgid), 
NULL, 16));
+                tmp = octstr_format("%lu", strtoll(octstr_get_cstr(msgid), 
NULL, 16));
             } else {
-                tmp = octstr_format("%llu", strtoll(octstr_get_cstr(msgid), 
NULL, 10));
+                tmp = octstr_format("%lu", strtoll(octstr_get_cstr(msgid), 
NULL, 10));
             }
         }