On 26.03.2010, at 10:23, Gabor Maros wrote: > > Hi, > > I've got a patch, but do not know how to submit it here. I enclosed the > patch and try to give a description, please accept it. > http://old.nabble.com/file/p28039894/dlr_mysql.diff dlr_mysql.diff > http://old.nabble.com/file/p28039894/dlr_mysql.c_new dlr_mysql.c_new > > Those messages are sent in the same secundum get the same FID from the same > emi smsc. Incoming delivery notifications must be paired not just according > to the FID but the target phone number. I corrected the 1.4.3 Stable code > and enclosed both the diff and the new code itself.
There are two issues with your patch: The timestamp is not unique in EMI/UCP however using the number can be an issue. For example in the case I have seen, I send to 079 2457333, but the delivery report comes back with 0041792457333. In other words, the SMSC does do numberconversions which makes above code fail. The second issue is that for all the other drivers, the "ts" value is unique and thus no other field needs to be used. I can imagine some protocols not coming back with any phone number but only a message-id. So those drivers would fail all the time. It might be better to do a search by ts and if that returns more than 1 record, then search by ts+number and if that returns 0, then search for a record with the same last 5 digits or so. It's not perfect but that's a limitation of EMI/UCP implementations of CMG. In our own SMSC, the TS value is larger and always unique which avoids the issue (on the other hand we always use SMPP). Andreas Fink Fink Consulting GmbH Global Networks Schweiz AG BebbiCell AG IceCell ehf --------------------------------------------------------------- Tel: +41-61-6666330 Fax: +41-61-6666331 Mobile: +41-79-2457333 Address: Clarastrasse 3, 4058 Basel, Switzerland E-Mail: [email protected] www.finkconsulting.com www.global-networks.ch www.bebbicell.ch --------------------------------------------------------------- ICQ: 8239353 MSN: [email protected] AIM: smsrelay Skype: andreasfink Yahoo: finkconsulting SMS: +41792457333 http://a-fink.blogspot.com/
