You mean bearerbox? Smppbox doesn't have a default version. The version is always indicated by the client. Box->version is set to 0x33 in box_create, but in practice, this version is never used.
Right now, we support both 0x33 and 0x34 clients. What do you want to change? == Rene -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Victor Luchitz Sent: donderdag 8 juli 2010 22:18 To: [email protected] Subject: Re: [PATCH] smppbox :: TLV support Well, by smsbox I meant that part of Kannel that implements SMPP support for SMSC's, sorry. As for the protocol version, what I assumed is that we can now default it to 0x34 instead of 0x33 or do you really want to keep 0x33 compatibility? Are there any pure 0x33 clients out there? 2010/7/9 Rene Kluwen <[email protected]>: > SMSBox doesn't do SMPP, does it? > And we could set the protocol version to 0x34 now. Just: Where in the code do > we set a version? > > == Rene > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of > Victor Luchitz > Sent: donderdag 8 juli 2010 21:55 > To: [email protected] > Subject: Re: [PATCH] smppbox :: TLV support > > SMSBox doesn't have such a check, so I assumed it would be fine not to > have them here either. We could also set the protocol version to 0x34 > now, don't you think? > > 2010/7/8 Rene Kluwen <[email protected]>: >> Wow, this is easier than I expected. I was expecting a long diff. >> >> IMO, we should ONLY send if the interface version (that is sent with the >> bind request) is at least 0x34. >> V3.3-clients could possibly choke on it. >> >> == Rene >> >> >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] On Behalf >> Of Victor Luchitz >> Sent: donderdag 8 juli 2010 19:58 >> To: [email protected] >> Subject: [PATCH] smppbox :: TLV support >> >> Hello. >> >> I'm attaching a patch against r17 that adds custom TLV support to >> DELIVER_SM, DATA_SM and SUBMIT_SM PDU's processed by smppbox. >> >> -- >> Best regards, >> Victor Luchitz >> >> > > > > -- > Best regards, > Victor Luchitz > > > > -- Best regards, Victor Luchitz
