Nope, check the patch, they implement their own PDU's, so it's either extending smsc_smpp to support those, or adding an extra smsc module (which is the cleanest approach imho). That, in addition to mapping those parameters into meta-data structures.
Using meta-data avoids having to modify the Msg structure, which is a good thing :) Regards, -- Alejandro Guerrieri [email protected] On 20/09/2010, at 19:02, Nikos Balkanas wrote: > That means that the patch is unnecessary and current SMPP driver can handle > it with only a configuration change. > > BR, > Nikos > ----- Original Message ----- From: "Rene Kluwen" <[email protected]> > To: "'Stipe Tolj'" <[email protected]> > Cc: "'kannel_dev_mailinglist'" <[email protected]> > Sent: Monday, September 20, 2010 6:25 PM > Subject: RE: [PATCH] CMPP2 (China Mobile Peer to Peer) module > > > I agree as well! > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf > Of Stipe Tolj > Sent: Monday, 20 September, 2010 15:14 > Cc: kannel_dev_mailinglist > Subject: Re: [PATCH] CMPP2 (China Mobile Peer to Peer) module > > Alejandro Guerrieri schrieb: >> --- gw/msg-decl.h (revision 4843) >> +++ gw/msg-decl.h (working copy) >> @@ -111,6 +111,11 @@ >> INTEGER(resend_try) >> INTEGER(resend_time) >> OCTSTR(meta_data) >> + OCTSTR(service_id) >> + OCTSTR(fee_usertype) >> + OCTSTR(fee_terminal_id) >> + OCTSTR(fee_type) >> + OCTSTR(fee_code) >> }) >> >> What about using meta-data for that? Assuming a separate smsc module is > used (unless all the new PDU's are implemented inside smsc_smpp?), using > meta-data to pass the specific parameters could be an option. > > yep, total agree here! > > Stipe > > -- > ------------------------------------------------------------------- > Kφlner Landstrasse 419 > 40589 Dόsseldorf, NRW, Germany > > tolj.org system architecture Kannel Software Foundation (KSF) > http://www.tolj.org/ http://www.kannel.org/ > > mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org > ------------------------------------------------------------------- > > > > >
