Hi,
A couple of trivial patches.
The first just addresses a few spelling errors I found while reading the
source.
The second one allows to pass the ssl-client-certkey-file option in an
smsc group. This allows to implement client side certificates for SMSc
connections.
This is useful if you want to make a connection to an SMSc needing
client side certificates, and since conn_open_ssl already supports
client certificates it is also pretty trivial to implement this
functionality in existing and new SMSCs.
thanks
Luca
Index: gwlib/fdset.c
===================================================================
--- gwlib/fdset.c (revision 4865)
+++ gwlib/fdset.c (working copy)
@@ -353,7 +353,7 @@
/* update event time */
time(&set->times[i]);
} else if (set->timeout > 0 && difftime(set->times[i] + set->timeout, now) <= 0) {
- debug("gwlib.fdset", 0, "Timeout for fd:%d appeares.", set->pollinfo[i].fd);
+ debug("gwlib.fdset", 0, "Timeout for fd:%d appears.", set->pollinfo[i].fd);
set->callbacks[i](set->pollinfo[i].fd, POLLERR, set->datafields[i]);
}
}
Index: contrib/web/sendsms.php
===================================================================
--- contrib/web/sendsms.php (revision 4865)
+++ contrib/web/sendsms.php (working copy)
@@ -144,7 +144,7 @@
$fields['text'] .= "%01"; # Version WBXML 1.1
$fields['text'] .= "%01"; # Unknown Public Identifier
$fields['text'] .= "%6A"; # Charset UTF-8
- $fields['text'] .= "%00"; # String table lenght
+ $fields['text'] .= "%00"; # String table length
$params = array ( "bearer" => "12", "proxy" => "13", "port" => "14", "name" => "15", "proxy_type" => "16", "url" => "17", "proxy_authname" => "18", "proxy_authsecret" => "19", "sms_smsc_address" => "1A", "ussd_service_code" => "1B", "gprs_accesspointname" => "1C", "ppp_logintype" => "1D", "proxy_logintype" => "1E", "csd_dialstring" => "21", "csd_calltype" => "28", "csd_callspeed" => "29", "ppp_authtype" => "22", "ppp_authname" => "23", "ppp_authsecret" => "24" );
Index: gw/ota_prov.c
===================================================================
--- gw/ota_prov.c (revision 4865)
+++ gw/ota_prov.c (working copy)
@@ -92,7 +92,7 @@
*/
/*
- * Append the User Data Header (UDH) including the lenght (UDHL). Only ports
+ * Append the User Data Header (UDH) including the length (UDHL). Only ports
* UDH here - SAR UDH is added when (or if) we split the message. This is our
* *specific* WDP layer.
*/
@@ -343,7 +343,7 @@
msg = msg_create(sms);
/*
- * Append the User Data Header (UDH) including the lenght (UDHL)
+ * Append the User Data Header (UDH) including the length (UDHL)
* WDP layer (start WDP headers)
*/
@@ -551,7 +551,7 @@
msg = msg_create(sms);
/*
- * Append the User Data Header (UDH) including the lenght (UDHL)
+ * Append the User Data Header (UDH) including the length (UDHL)
* WDP layer (start WDP headers)
*/
Index: gwlib/cfg.def
===================================================================
--- gwlib/cfg.def (revision 4865)
+++ gwlib/cfg.def (working copy)
@@ -389,6 +389,7 @@
OCTSTR(max-sms-octets)
OCTSTR(login-prompt)
OCTSTR(password-prompt)
+ OCTSTR(ssl-client-certkey-file)
OCTSTR(generic-param-username)
OCTSTR(generic-param-password)
OCTSTR(generic-param-from)
