Hi, i send patch soon. Fixing leaks now.
Aarno On 01.02.2012, at 21:30, Hillel wrote: > Hi, > > Any news on your patch, that we are excited to try out? > > regards > > ---------------------------------------------------------------------- > > Message: 1 > Date: Mon, 16 Jan 2012 09:06:15 +0100 > From: Aarno Syv?nen <[email protected]> > To: "Hillel Bilman" <[email protected]> > Cc: "[email protected] Devel" <[email protected]> > Subject: Re: Opwnsmppbox patch > Message-ID: <[email protected]> > Content-Type: text/plain; charset=us-ascii > > Hi Hillel, > > I am ending the testing of new version, which does not change Kannel. I will > post it soon. > > Aarno > > On 15.01.2012, at 08:19, Hillel Bilman wrote: > >> Hi Aarno, >> >> How far are the patches so that they can be accepted into SVN? >> We would like to use them once they have been accepted by Alex. >> >> rgds >> >> ---------------------------------------------------------------------- >> Date: Mon, 19 Dec 2011 20:11:07 +0100 >> From: Alexander Malysh <[email protected]> >> To: Aarno Syv?nen <[email protected]> >> Cc: [email protected] >> Subject: Re: Opwnsmppbox patch >> Message-ID: <[email protected]> >> Content-Type: text/plain; charset=iso-8859-1 >> >> Hi Aarno, >> >> I don't like gw dlr part at all. It's: >> a) not complete, not all all DB types implemented >> b) not C style at some places (variables defined within function) >> c) why use only 8 chars when using smpp_id? >> d) why not add flag to dlr_find which decide to always add DLR to storage? >> e) I don't see use cases >> >> Thanks, >> Alex >> >> Am 19.12.2011 um 17:15 schrieb Aarno Syv?nen: >> >>> Hi List, >>> >>> here are diffs again >>> >>> to Kannel, for documentation >>> <doc.diff> >>> >>> for gw >>> >>> <gw.diff> >>> >>> for gwlib >>> >>> <gwlib.diff> >>> >>> for opensmppbox, for documentation >>> >>> <doc.diff> >>> >>> for code >>> <box.diff> >>> >>> Aarno >>> >> >> >> >> >> ------------------------------ >> Date: Tue, 20 Dec 2011 11:37:35 +0100 >> From: Aarno Syv?nen <[email protected]> >> To: Alexander Malysh <[email protected]> >> Cc: [email protected] >> Subject: Re: Opwnsmppbox patch >> Message-ID: <[email protected]> >> Content-Type: text/plain; charset=iso-8859-1 >> >> Hi Alex >> >> a) I can add code for other DB tzpes, but someone lese must test them. >> I do not have Oracle ;) >> b) Will fix the style >> c) Opensmppbox uses 8 char id. V3.3 issue, i think. >> d) I do not like flags, generally. But I will, of course, fix the style. >> e) Opensmppbox uses the patch. Do you think that this should be part >> of opensmppbox instead ? >> >> Aarno >> >> On Dec 19, 2011, at 8:11 PM, Alexander Malysh wrote: >> >>> Hi Aarno, >>> >>> I don't like gw dlr part at all. It's: >>> a) not complete, not all all DB types implemented >>> b) not C style at some places (variables defined within function) >>> c) why use only 8 chars when using smpp_id? >>> d) why not add flag to dlr_find which decide to always add DLR to > storage? >>> e) I don't see use cases >>> >>> Thanks, >>> Alex >>> >>> Am 19.12.2011 um 17:15 schrieb Aarno Syv?nen: >>> >>>> Hi List, >>>> >>>> here are diffs again >>>> >>>> to Kannel, for documentation >>>> <doc.diff> >>>> >>>> for gw >>>> >>>> <gw.diff> >>>> >>>> for gwlib >>>> >>>> <gwlib.diff> >>>> >>>> for opensmppbox, for documentation >>>> >>>> <doc.diff> >>>> >>>> for code >>>> <box.diff> >>>> >>>> Aarno >>>> >>> >>> >> >> >> > > > > >
