Hi Andreas,
first off all please fix indents :-)
conn_name = conn ? smscconn_name(conn) : octstr_imm("unknown");
+ Octstr *conn_smsc_specific = NULL;
+ if(conn) {
+ if (conn->smsc_specific_status) {
+ conn_smsc_specific =
octstr_duplicate(conn->smsc_specific_status);
+ }
+ }
This is not C-Style and please don't use tabs...
As to the patch: it looks ok but you have to test/patch kannel.monitor and the
other contrib things.
Thanks,
Alex
Am 21.06.2012 um 12:08 schrieb Andreas Fink:
> Hi folks,
>
> I'm working on improving the AT driver again, the project which brought me to
> kannels 11 years ago (time goes fast)
>
> The attached patch does add a new status information to the status page which
> includes things like IMSI, Card ID, MSISDN (if available) etc.
> This is very useful if you use USB adapters which change their naming based
> on where they are plugged or when they are plugged or when you dont know
> which port name matches which physical port.
>
> So instead of seeing a line on http://localhost:1234t/status
>
> port14[port14] AT2[port14] (online 1s, rcvd: sms 0 (0.00,0.00,0.00) /
> dlr 0 (0.00,0.00,0.00), sent: sms 0 (0.00,0.00,0.00) / dlr 0
> (0.00,0.00,0.00), failed 0, queued 0 msgs)
>
>
> You will see something liek this:
>
>
> port14[port14] AT2[port14] (online 24s, rcvd: sms 0 (0.00,0.00,0.00) /
> dlr 0 (0.00,0.00,0.00), sent: sms 0 (0.00,0.00,0.00) / dlr 0
> (0.00,0.00,0.00), failed 0, queued 0 msgs)
> CurrentOperator: 22802 Signal: 17 CardNumber: 89410212614001299889
> Device: /dev/cu.usbserial-001412FAC
>
>
> Before committing this it to SVN, I would like to have a few guys test this
> with other modem types (in my case I used Wavecom's) to see if its properly
> working there too.
>
>
> <modem-patch.txt>
>
>
> Also in my setup delivery reports don't work but i have not figured out why
> yet. Looks like the modems never give them back to me. Anybody seen this
> working in his setup?
>
>
> Andreas Fink
>
