I also was looking into this.
Is it possible he wanted msg_escaped in place of msg so when inserting into
db, validity has the original value in minutes?
if (msg_type(msg) == sms) {
debug("sqlbox", 0, "smsbox_to_bearerbox: sms received");
msg_escaped = msg_duplicate(msg);
/* convert validity & deferred to minutes */
if (msg_escaped->sms.validity != SMS_PARAM_UNDEFINED)
msg_escaped->sms.validity = (msg_escaped->sms.validity -
time(NULL))/60;
if (msg_escaped->sms.deferred != SMS_PARAM_UNDEFINED)
msg_escaped->sms.deferred = (msg_escaped->sms.deferred -
time(NULL))/60;
gw_sql_save_msg(msg_escaped, octstr_imm("MT"));
msg_destroy(msg_escaped);
}
send_msg(conn->bearerbox_connection, conn, msg);
Br, Rinor
On Sat, Feb 16, 2013 at 3:36 PM, Rene Kluwen <[email protected]> wrote:
> Also: in sqlbox.c (function smsbox_to_bearerbox()):****
>
> ** **
>
> /* convert validity & deferred to minutes */****
>
> if (msg->sms.validity != SMS_PARAM_UNDEFINED)****
>
> msg->sms.validity = (msg->sms.validity -
> time(NULL))/60;****
>
> if (msg->sms.deferred != SMS_PARAM_UNDEFINED)****
>
> msg->sms.deferred = (msg->sms.deferred -
> time(NULL))/60;****
>
> ** **
>
> Isn’t this field encoded twice now? Once in smsbox and another time in
> sqlbox?****
>
> ** **
>
> Alexander, you made this change. Please shed some light.****
>
> ** **
>
> *From:* [email protected] [mailto:[email protected]] *On
> Behalf Of *Rene Kluwen
> *Sent:* vrijdag 15 februari 2013 15:16
> *To:* [email protected]
> *Subject:* Validity perdiod****
>
> ** **
>
> I came across an issue since svn version 4956 of smsbox.c, using smpp.****
>
> ** **
>
> The logs show the following:****
>
> ** **
>
> 2013-02-15 14:52:45 [3144] [7] DEBUG: validity_period: "711110215159000+"
> ****
>
> ** **
>
> This was this afternoon at 14:52. The validity field of the sendsms
> interface was not set.****
>
> ** **
>
> How do I interpret this as “*YYMMDDhhmmsstnnp*”?****
>
> ** **
>
> One of my clients needed to downgrade because of this issue.****
>
> ** **
>
> == Rene****
>
