Personally, I am happy someone looked at Kannel with a fresh eye and did some sanity tests. As a developer, we sometimes look over our own silly bugs.
Kannel is a volunteer project. That's why sometimes things that take more time can be post poned. But I will try to find some hours to look at your patches. == Rene -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Aris Adamantiadis Sent: zaterdag 16 februari 2013 21:43 To: [email protected] Subject: Re: Multiple patches for Kannel Hi Everyone, Was someone able to inspect my patches and give some feedback ? I hope the 48 different patches did not frighten anyone :) I'm still available if there's some issue or question on a change. Kr, Aris Le 8/02/13 13:49, Aris Adamantiadis a écrit : > Hello, > > While the test haven't completed, I will not have much time later to > work with the patches so here it is. > As you can see, it has been split into 48 different files. (hence the > .tgz) Not all of them are of equal importance. > They all apply to kannel 1.5.0-release. I did not try to cherry pick > them in the current branch. > Some special patches: > 0001-Changements-de-Martin.patch: This fixes a problem with the Oracle > SQL expression (Already fixed in svn I think), but also a problem in > text conversion, in which an SMS containing only ciphers would be > converted into ascii (This causes problem when kannel is used to send > one time passwords). > 0047-cherry-pick-of-gsoap-ParlayX-support.patch: This is a backport of > ParlayX on 1.5.0. > 0048-Fix-out-of-bound-read-strcpy-to-memcpy.patch: A potential bug I > fixed in the ParlayX code. I believe this will apply perfectly on the > svn branch. > > It's possible that some patches contain /* flawfinder: ignore */. It > is perfectly safe not to merge these lines ! > Kind regards, > > Aris >
