Hi, for improvement +1 for the implementation -1. You change a way how we used rwlock . Rwlock is to protect log file list and not the output. Please keep rwlock in place then +1 from me.
Alex Am 02.10.2013 um 17:52 schrieb Jacek Raczkiewicz <jacek.raczkiew...@gmail.com>: > Hi, > > I have been working on imrpving application that uses a lot libraries from > kannel/gwlib. > I noticed that logging function does format the string even if there is no > intention to save it to the log due to configured log level. > My improvement is that I moved the format() function inside the conditional > block which check for log level. > This really make a difference when logged string is large (in our case it may > be as big as 1MB) and that is formatted for no reason. > > Please include this fix into kannel codebase. > > Regards > Jacek Raczkiewicz > <logging.diff>
