Hi Stipe,
this chunk -1:
+ /* PDU allowed payload size is 64K, so change max SMS octet value */
+ if (cfg_get_bool(&smpp->message_payload, grp,
octstr_imm("message-payload")) == 1)
+ conn->max_sms_octets = 65536;
I would prefer that user set max-sms-octets in the config because this will
break many installations and this is even wrong
because if user set max-sms-octets in the config you just overwrite it here and
user has no chance to change it.
Alex
Am 30.05.2014 um 16:09 schrieb Stipe Tolj <[email protected]>:
> Am 26.05.2014 18:59, schrieb Alexander Malysh:
>> Hi Stipe,
>>
>> why this limit of 254? It's hard to explain for users what this mean, IMHO.
>> I think, the beast would be to have config switch to use
>> either short_message or message_payload. Another argument for simple switch
>> that some SMSCs expect message_payload even
>> for short message body.
>
> adressing the concerns of Alex, please find here another variant of the
> patchset which uses a simple boolean switch in the config group, i.e.:
>
> group = smsc
> smsc = smpp
> ...
> message-payload = yes
> ...
>
> to switch over to the use of submit_sm.mesage_payload instread of
> .short_message. Messages up to 64K in size are then not segmented and send as
> one PDU.
>
> Comments, votes please.
> Stipe
>
> --
> -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 Düsseldorf, NRW, Germany
>
> tolj.org system architecture Kannel Software Foundation (KSF)
> http://www.tolj.org/ http://www.kannel.org/
>
> mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org
> -------------------------------------------------------------------
> <smpp-message-payload.v2.diff>
