Hi,

patch looks mostly ok except this part:

+    if ( dlr_mask < -1 || dlr_mask > 255 ) { /* 11111111 */

Why 255 ? 

Max dlr-msk what we have:
#define DLR_UNKNOWN         0x40|DLR_FAIL

=> 66

Please fix and if no objections I will commit it.

Thanks,
Alex


> Am 02.10.2016 um 21:07 schrieb Iwan Iwanowicz <iwa...@gmail.com>:
> 
> Hi,
> 
> Please take a look on smpp and cimd2 patch so now those protocols can support 
> DLR_EXPIRED.
> 
> Best regards
> Marcin 'Iwan' K-k.
> <kannel_smpp_cimd2_expiration.patch>

Reply via email to