+1 from me.

------ Origineel bericht ------
Van: "Stipe Tolj" <st...@kannel.org>
Aan: "devel@kannel.org" <devel@kannel.org>
Verzonden: 2-10-2017 13:03:34
Onderwerp: [PATCH] constant SMPP TLV support

Hi list,

we have a fairly robust construct to add optional TLVs for SMPP SMSCs via the meta-data construct, when messages are injected via smsbox's sendsms HTTP interface.

Though, it would be nice if we could set "constant default" values for smsc-ids that would be set as optional TLVs, even if no values in msg->sms.meta_data are provided.

The attached patch implements such a functionality, by allowing to define:

 group = smpp-tlv
 name = charging-id
 tag = 0x2010
 type = octetstring
 length = 10
 smsc-id = "smpp_deadend"
 const = "xyz"

and adding the 'const' directive that can set a constant value.

So, if there is no TLV coming via the msg->sms.meta_data part, then the constant is set for that particular TLV.

Comments welcome. If no objections, will commit to SVN trunk the coming days.

-- Best Regards,
Stipe Tolj

-------------------------------------------------------------------
Düsseldorf, NRW, Germany

Kannel Foundation                 tolj.org system architecture
http://www.kannel.org/ http://www.tolj.org/

st...@kannel.org s...@tolj.org
-------------------------------------------------------------------


Reply via email to