Hi Jon,

This is not the pre-B3 issue that I'm trying to track down, but it's
probably a good idea to have this; i2c_attach_client *can* fail.  If it
looks okay to you, I'll commit to master.


diff --git a/drivers/media/video/ov7670.c b/drivers/media/video/ov7670.c
index dcdeab2..cf1a1ed 100644
--- a/drivers/media/video/ov7670.c
+++ b/drivers/media/video/ov7670.c
@@ -1264,7 +1264,9 @@ static int ov7670_attach(struct i2c_adapter *adapter)
 	ret = ov7670_detect(client);
 	if (ret)
 		goto out_free_info;
-	i2c_attach_client(client);
+	ret = i2c_attach_client(client);
+	if (ret)
+		goto out_free_info;
 	return 0;
 
   out_free_info:
_______________________________________________
Devel mailing list
[email protected]
http://mailman.laptop.org/mailman/listinfo/devel

Reply via email to