> > @@ -1206,7 +1206,7 @@ static void slic_link_event_handler(struct adapter > > *adapter) > > #else > > Stop compilation; > > #endif > > - ASSERT((status == STATUS_SUCCESS) || (status == STATUS_PENDING)); > > + ASSERT(status == 0); > > } > > > > Now that looks useless since slic_upr_request can return STATUS_PENDING > or -ENOMEM. Same for slic_config_get Yes, it seems that slic_link_event_handler & slic_config_get have to return error codes.
> > @@ -2267,7 +2267,7 @@ static u32 slic_card_locate(struct adapter *adapter) > > > > ASSERT(card); > > if (!card) > > - return STATUS_FAILURE; > > + return -ENOMEM; > > Is -ENOMEM correct for this case? > Right, maybe ENXIO? _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
