Martyn Welch wrote:
> Gustavo Silva wrote:
>
>> This is a patch to the vme_user.c file that fixes up the following
>> issues:
>>
>> WARNING: please, no space before tabs
>> x 12
>> ERROR: code indent should use tabs where possible
>> x 15
>> WARNING: braces {} are not necessary for single statement blocks
>> x 2
>> WARNING: printk() should include KERN_ facility level
>> x 3
>> ERROR: "foo * bar" should be "foo *bar"
>> x 1
>> ERROR: space required before the open brace '{'
>> x 3
>> WARNING: space prohibited between function name and open parenthesis '('
>> x 1
>> ERROR: spaces required around that '=' (ctx:VxV)
>> x 2
>> ERROR: spaces required around that '<' (ctx:VxV)
>> x 2
>> ERROR: space required after that ',' (ctx:VxV)
>> x 3
>> ERROR: spaces required around that '?' (ctx:VxW)
>> x 1
>> ERROR: space required before the open parenthesis '('
>> x 1
>> WARNING: braces {} are not necessary for single statement blocks
>> x 2
>>
>>
>>
>
> This looks very familiar - I'm sure there was a patch already on the
> mailing list doing this, but it has some issues which I don't think were
> ever addressed. This one looks good though.
>
>
Hmm, seems the earlier patch was fixed up and is now in linux-next, sorry.
Martyn
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E [email protected] | M2 3AB VAT:GB 927559189
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
