We have nice method simple_strtoul() to convert string to numbers which
could be used here.

Signed-off-by: Andy Shevchenko <[email protected]>
---
 drivers/staging/panel/panel.c |   19 +++++++------------
 1 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 8bd7182..3e07e41 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -48,6 +48,7 @@
 #include <linux/fcntl.h>
 #include <linux/init.h>
 #include <linux/delay.h>
+#include <linux/kernel.h>
 #include <linux/ctype.h>
 #include <linux/parport.h>
 #include <linux/version.h>
@@ -1179,22 +1180,16 @@ static inline int handle_lcd_special_code(void)
                        break;
 
                while (*esc) {
+                       char *endp;
+
                        if (*esc == 'x') {
                                esc++;
-                               lcd_addr_x = 0;
-                               while (isdigit(*esc)) {
-                                       lcd_addr_x = lcd_addr_x * 10 +
-                                                    (*esc - '0');
-                                       esc++;
-                               }
+                               lcd_addr_x = simple_strtoul(esc, &endp, 10);
+                               esc = endp;
                        } else if (*esc == 'y') {
                                esc++;
-                               lcd_addr_y = 0;
-                               while (isdigit(*esc)) {
-                                       lcd_addr_y = lcd_addr_y * 10 +
-                                                    (*esc - '0');
-                                       esc++;
-                               }
+                               lcd_addr_y = simple_strtoul(esc, &endp, 10);
+                               esc = endp;
                        } else
                                break;
                }
-- 
1.7.1.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to