On Wed, Sep 8, 2010 at 12:18 AM, Vipin Mehta <[email protected]> wrote: > Andy, > Thanks for the patch. Although the driver supports Linux but it has been > architected to support other OSes if desired. The code is, therefore, > organized into generic and OS specific components with the latter part of the > code captured into the os/linux directory. As such, the patch will be more > useful if we can move out the inclusion of linux specific header files > <linux/kernel.h> and <linux/ctype.h> into a header file in os/linux/include > directory. You can refer to os/linux/include/osapi_linux.h for example. A > macro could be defined which would use linux specific APIs for Linux and keep > the original definitions for any other OS.
The file ar3kpsparser.h, which is directly included by patched one, contains few includes like <linux/XXX.h>. Due to this I consider this part of code as OS-dependent. That's why I decide to put necessary headers inside c-file. Thus I think patch could be applied w/o modifications. However, If you want to do me some odd stuff (at least until I have not got the clear explanation), I could provide you 3 patches: clean up file under os/linux, remove unused macros, and fix in ar3kpsparser in way when necessary os-dependent headers will be located at some common header. -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
