On Tue, Sep 07, 2010 at 09:16:46AM +0200, walter harms wrote:
> 
> 
> Greg KH schrieb:
> > On Mon, Sep 06, 2010 at 09:51:20AM +0200, walter harms wrote:
> >> the indention should be fixed also.
> > 
> > Yes, the indentation for the whole file should be fixed, but that's not
> > what this patch was doing.
> > 
> > Remember, a patch should only do one thing at a time.
> > 
> 
> that is true,
> but in this special case i nearly missed the #if because it is so hidden
> in the code. IMHO that is enough for an exception.

This whole driver needs major help.  But again, one thing at a time
please.

thanks,

greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to