This is a patch that fixes up, macros with multiple statements should be 
enclosed in a do - while loop, coding style issue in the adl_pci9111.c file 
found by the checkpatch.pl tool

Signed-off-by: Maurice Dawson <[email protected]>
---
 drivers/staging/comedi/drivers/adl_pci9111.c |   21 +++++++++++++++------
 1 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c 
b/drivers/staging/comedi/drivers/adl_pci9111.c
index 96c4f30..18103b6 100644
--- a/drivers/staging/comedi/drivers/adl_pci9111.c
+++ b/drivers/staging/comedi/drivers/adl_pci9111.c
@@ -266,19 +266,28 @@ TODO:
        outb(flags, PCI9111_IO_BASE+PCI9111_REGISTER_8254_CONTROL)
 
 #define pci9111_8254_counter_0_set(data) \
-       outb(data & 0xFF, PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_0); \
+       do { \
+               outb(data & 0xFF, \
+                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_0); \
                outb((data >> 8) & 0xFF, \
-                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_0)
+                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_0); \
+       } while (0)
 
 #define pci9111_8254_counter_1_set(data) \
-       outb(data & 0xFF, PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_1); \
+       do { \
+               outb(data & 0xFF, \
+                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_1); \
                outb((data >> 8) & 0xFF, \
-                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_1)
+                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_1); \
+       } while (0)
 
 #define pci9111_8254_counter_2_set(data) \
-       outb(data & 0xFF, PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_2); \
+       do { \
+               outb(data & 0xFF, \
+                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_2); \
                outb((data >> 8) & 0xFF, \
-                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_2)
+                       PCI9111_IO_BASE+PCI9111_REGISTER_8254_COUNTER_2); \
+       } while (0)
 
 /*  Function prototypes */
 
-- 
1.7.0.4

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to