On Thu, Oct 21, 2010 at 11:23 AM, Greg KH <[email protected]> wrote: ... > I changed FALSE to false, not you, or broadcom, just look at commit > 0965ae88aff802ff48fa2f35fff29feff2754962 in linux-next :)
Sorry - I was just too lazy to look that up. :) >> (no offense intended to whoever submitted that patch; Just expressing my >> needs.) > > That's nice, but this is the very first time I have every heard of this, > how was I supposed to guess this before now? If that an apology, I'll take it. :) You (and I and most people) will never know everything that is going on. It's the nature of "High Tech" HW development. "Unwillingness to give up competitive advantage" is why Linux is a "lagging technology" (WRT to HW support) and always will be. >> > I don't see any patches here from you. >> >> Are you suggesting signed-off-by lines are the only thing worth to measure? >> Testing and code review not worth anything? > > It is, but again, I have not seen anything from you for this before now. > It is between you and Broadcom for them not crediting you with anything, > how can you expect me to know this? How about just not assuming you would have known? Most of the time people ignore who submitted trivial changes anyway (e.g. FALSE->false). No one is going to care next year who did initial testing of drivers/staging/brcm80211/brcmfmac driver. Probably only a handful of people care now anyway and they already know. >> Or is advice/criticism hard to accept gracefully? (e.g. "thanks, but no.") >> >> I don't think I've deserved getting my ears boxed over this. I'm honestly >> trying to be constructive. I apologize if my message came across as if >> I own your sandbox. >> >> BTW, factually, this comment is not true. Maybe overlooked the >> patch I submitted recently because it was mis-attributed? >> >> commit 93ad12cf1a8c3be46d66581a7acaa1c7fce590e2 >> Author: nohee ko <[email protected]> >> Date: Tue Oct 5 18:05:04 2010 -0700 >> >> staging: brcm80211: bug fix for n_ssids usage and update drv_info >> >> -update drv_info so it's visible in "ethtool -i" output >> -remove n_ssids usage. Fixes nullptr deref bug seen before. >> >> Signed-off-by: Grant Grundler <[email protected]> >> Acked-by: Nohee Ko <[email protected]> >> Signed-off-by: Greg Kroah-Hartman <[email protected]> > > Ick, I did overlook that. > > Did you really write that? Yes. I sent to Broadcom for review/approval since some of the HW involves NDA and asked them to forward with their Ack-by if it was good. I'm probably the one who needs to read SubmittingPatches again. > If so, Nohee messed up big time. You should have gotten the proper > credit for it. Nohee isn't the "subsystem" maintainer. :) > Nohee, go re-read Documentation/SubmittingPatches for how to properly > attribute the author of a patch. Please don't make that mistake again. It's not a big deal to me. It happens. I or anyone else probably wouldn't have noticed if this thread hadn't made me look for it. > Here's my feedback, "I need to see more cleanup happening before we can > take new features" :) > > I've made this before to other companies. It's a carrot to use to get > things moving when I think it isn't. Ok. Good enough. Can you please restate when (Which milestone) would you like Broadcom to resubmit the two feature patches? e.g. some specific milestone? I read "try again later" on the original reply. thanks, grant _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
