It's odd.

I've checked it before submission:

a...@fs-test:~/prj/linux-2.6(mine)$ git show
77099f0afe94928b5b0066a7efa5fa9f81696b54 | scripts/checkpatch.pl -
total: 0 errors, 0 warnings, 177 lines checked

Your patch has no obvious style problems and is ready for submission.

On Tue, Oct 26, 2010 at 12:43 AM, Sven Eckelmann <[email protected]> wrote:
> 77099f0afe94928b5b0066a7efa5fa9f81696b54 added changes to vis.c which
> trigger a checkpatch.pl warning about braces which are not necessary
> anymore.
>
> WARNING: braces {} are not necessary for any arm of this statement
> +               if (entry->primary)
> [...]
> +               else {
> [...]
>
> Signed-off-by: Sven Eckelmann <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Marek Lindner <[email protected]>
> Cc: Simon Wunderlich <[email protected]>
> Cc: Andrew Lunn <[email protected]>
> ---
>  drivers/staging/batman-adv/vis.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/batman-adv/vis.c 
> b/drivers/staging/batman-adv/vis.c
> index 3d2c1bc..4473cc8 100644
> --- a/drivers/staging/batman-adv/vis.c
> +++ b/drivers/staging/batman-adv/vis.c
> @@ -135,9 +135,8 @@ static ssize_t vis_data_read_prim_sec(char *buff, struct 
> hlist_head *if_list)
>        hlist_for_each_entry(entry, pos, if_list, list) {
>                if (entry->primary)
>                        len += sprintf(buff + len, "PRIMARY, ");
> -               else {
> +               else
>                        len += sprintf(buff + len,  "SEC %pM, ", entry->addr);
> -               }
>        }
>
>        return len;
> --
> 1.7.2.3
>
>



-- 
With Best Regards,
Andy Shevchenko
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to