On 26/10/10 02:11, Emilio G. Cota wrote:
> From: Emilio G. Cota <[email protected]>
> 
> The resource is about to be freed and therefore it is pointless to
> set any of its parameters.

Nope - this is disabling the window, which given that you are about to
unalloc the memory that it is using this is quite important.

Martyn

> 
> Signed-off-by: Emilio G. Cota <[email protected]>
> ---
>  drivers/staging/vme/devices/vme_user.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c 
> b/drivers/staging/vme/devices/vme_user.c
> index 95c22ff..a1cb85b 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -851,7 +851,6 @@ static int __devexit vme_user_remove(struct device *dev, 
> int cur_bus, int cur_sl
>               kfree(image[i].kern_buf);
>  
>       for (i = SLAVE_MINOR; i < (SLAVE_MAX + 1); i++) {
> -             vme_slave_set(image[i].resource, 0, 0, 0, 0, VME_A32, 0);
>               buf_unalloc(i);
>               vme_slave_free(image[i].resource);
>       }


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square,
Manchester,
E [email protected]                        |   M2 3AB  VAT:GB 927559189
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to